-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for flowing the Activity/distributed trace context via SignalR invocations #18711
Comments
If we expanded Hub Pipeline to work on the client as well, this could probably be done in that. |
@anurse it also needs to be done client side. @SergeyKanzhelev We should have a quick sync about this. |
Thanks for contacting us. |
We have headers in messages, we could finally use them here @BrennanConroy. It'll end up allocating async locals though... |
We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process. |
Ha. I just spent a lot of time getting my .NET 6 application in my k8s cluster to post its metrics and traces through otelcol to jaeger, only to find out that the SignalR integration just isn't there. That's pretty disappointing from where I sit right now, so I'm leaving a comment to remind people that this is an important issue. :) |
For everyone else who struggles with this, there's work in progress here to fix this: #46164 |
We need to make a provision in the SignalR hub protocol for flowing the distributed trace context. This will enable causality tracking across multiple SignalR applications or from an HTTP server calling a SignalR method. It's also worth thinking about what it means to flow the context back to the client for server -> client invocations.
The text was updated successfully, but these errors were encountered: