Skip to content

FromServicesAttribute not optional #20444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Apr 2, 2020 · 4 comments · Fixed by #39804
Closed

FromServicesAttribute not optional #20444

ghost opened this issue Apr 2, 2020 · 4 comments · Fixed by #39804
Labels
affected-very-few This issue impacts very few customers enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-model-binding old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels severity-nice-to-have This label is used by an internal tool
Milestone
.NET 7 Planning

Comments

@ghost
Copy link

ghost commented Apr 2, 2020

In constructors I can make arguments optional by settings it's default value to null - this is not working for this attribute.
@javiercn javiercn added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 2, 2020
@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Apr 2, 2020
@mkArtakMSFT
Copy link
Contributor

We've moved this issue to the Backlog milestone. This means that it is not going to happen for the coming release. We will reassess the backlog following the current release and consider this item at that time. However, keep in mind that there are many other high priority features with which it will be competing for resources.

@mkArtakMSFT mkArtakMSFT added this to the Backlog milestone Apr 2, 2020
@ghost
Copy link
Author

ghost commented Apr 2, 2020

Sure, thank you

@pranavkm pranavkm added affected-very-few This issue impacts very few customers severity-nice-to-have This label is used by an internal tool labels Nov 6, 2020
@mkArtakMSFT mkArtakMSFT added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Oct 14, 2021
@ghost
Copy link

ghost commented Dec 28, 2021

Thanks for contacting us.

We're moving this issue to the .NET 7 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@brunolins16 brunolins16 linked a pull request Apr 19, 2022 that will close this issue
Inferring FromServices optionality #39804
Merged
@brunolins16
Copy link
Member

Fixed by #39804

@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affected-very-few This issue impacts very few customers enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-model-binding old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels severity-nice-to-have This label is used by an internal tool
Projects
None yet
Milestone
.NET 7 Planning
Development

Successfully merging a pull request may close this issue.

Inferring FromServices optionality brunolins16/aspnetcore
5 participants
@pranavkm @javiercn @brunolins16 @mkArtakMSFT @rafikiassumani-msft