Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Blazor to .NET 5 #20519

Closed
pranavkm opened this issue Apr 3, 2020 · 0 comments
Closed

Move Blazor to .NET 5 #20519

pranavkm opened this issue Apr 3, 2020 · 0 comments
Assignees
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Apr 3, 2020

Runtime and tools story

The .NET WebAssembly team is driving the work for a build pipeline for a WASM. Once we have designs for it available, we'll have to figure out how blazor fits in to it. Partner work is TBD at this point

Detecting a blazor-wasm project

The SDK will need some way of knowing if a project is a Blazor WASM application to enable BlazorWASM specific targets of the build pipleline. One option might be to rely on a WASM specific rid if that's available. A better option would be to use an explicit property. Mvc applications do this (AddRazorSupportForMvc) and so do WinForms applications UseWindowsForms so there's incentive to be consistent:

<PropertyGroup>
    <TargetFramework>net5</TargetFramework>
    <UseBlazorWebAssembly>true</UseBlazorWebAssembly>
  </PropertyGroup>

Sharing the linker

With the compiler (csc), we re-use it tasks, but not it's targets. There's additional overhead in making sure these targets are kept up to date with the task, but we've shipped targets for CSC this way in RazorSDK for a while now, and there isn't an alternative that is clearly better.

Dev-Server, DebugProxy

Tools that ship as part of the WebSDK, similar to dev-certs, user secrets etc.

@pranavkm pranavkm added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Apr 3, 2020
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Apr 6, 2020
@pranavkm pranavkm changed the title Figure out how implementation for shipping blazor-wasm in 5.0 SDK Figure out implementation for shipping blazor-wasm in 5.0 SDK Apr 28, 2020
@mkArtakMSFT mkArtakMSFT changed the title Figure out implementation for shipping blazor-wasm in 5.0 SDK Move Blazor to .NET 5 Jun 5, 2020
@mkArtakMSFT mkArtakMSFT added enhancement This issue represents an ask for new feature or an enhancement to an existing one and removed task labels Jun 5, 2020
@pranavkm pranavkm removed the Working label Jun 24, 2020
@mkArtakMSFT mkArtakMSFT added the Done This issue has been fixed label Jul 8, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Development

No branches or pull requests

2 participants