-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Quarantined test: BundlesScopedCssFiles_UpdatesBundleWhenContentsChange #25623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Why isn't it marked quarantined then? |
The PR that quarantines it isn’t yet merged. |
@BrennanConroy Is there anything wrong here? |
Thanks for contacting us. |
@javiercn I think we can improve the way the test is written here. The issue happens when we check to see that the last-modified timestamp of the compiled CSS does not change if the file contents haven't (ref). The way we determine the timestamps results in a millisecond variance in the test environment which causes the check to fail. We should either (1) read the timestamp from the file directly or (2) update the test to account for millisecond variance in last modified datetime. |
We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process. |
This test is currently our flakiest, with 118 failures out of 373 runs. Glad to see you've got a PR out for it! |
We shipped a code change to improve the test here. Hopefully, we'll be able to unquarantine this test in 30 days. |
@captainsafia or @dotnet/aspnet-blazor-eng in general, I'd also appreciate your thoughts on simply skipping this test in release/5.0. It's only about 30% successful and therefore isn't providing any value. |
Reopening because I'm about to |
@mkArtakMSFT not sure what action you expect me to take here. |
@javiercn need to address the stability issue with this test. Let's target to do this in 7.0 |
@mkArtakMSFT this test is not flaky, the issue is from 2 years ago. I'm closing this as there's no action to be taken here |
It's failing on Helix even though it passes locally and in other CI environments:
https://dev.azure.com/dnceng/public/_build/results?buildId=802210&view=ms.vss-test-web.build-test-results-tab&runId=25400452&resultId=107994&paneView=debug
The text was updated successfully, but these errors were encountered: