Skip to content

Quarantined test: BundlesScopedCssFiles_UpdatesBundleWhenContentsChange #25623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SteveSandersonMS opened this issue Sep 4, 2020 · 13 comments
Closed
Assignees
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates test-failure

Comments

@SteveSandersonMS
Copy link
Member

It's failing on Helix even though it passes locally and in other CI environments:

https://dev.azure.com/dnceng/public/_build/results?buildId=802210&view=ms.vss-test-web.build-test-results-tab&runId=25400452&resultId=107994&paneView=debug

@SteveSandersonMS SteveSandersonMS added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 4, 2020
@BrennanConroy
Copy link
Member

Why isn't it marked quarantined then?

@SteveSandersonMS
Copy link
Member Author

The PR that quarantines it isn’t yet merged.

@javiercn
Copy link
Member

javiercn commented Sep 7, 2020

@BrennanConroy Is there anything wrong here?

@javiercn javiercn added this to the Next sprint planning milestone Sep 7, 2020
@ghost
Copy link

ghost commented Sep 7, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@captainsafia
Copy link
Member

@javiercn I think we can improve the way the test is written here. The issue happens when we check to see that the last-modified timestamp of the compiled CSS does not change if the file contents haven't (ref). The way we determine the timestamps results in a millisecond variance in the test environment which causes the check to fail. We should either (1) read the timestamp from the file directly or (2) update the test to account for millisecond variance in last modified datetime.

@ghost
Copy link

ghost commented Oct 9, 2020

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@Tratcher
Copy link
Member

This test is currently our flakiest, with 118 failures out of 373 runs. Glad to see you've got a PR out for it!

@ghost ghost added Done This issue has been fixed and removed Working labels Nov 9, 2020
@captainsafia
Copy link
Member

We shipped a code change to improve the test here. Hopefully, we'll be able to unquarantine this test in 30 days.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
@dougbu
Copy link
Member

dougbu commented Jan 7, 2022

@captainsafia or @dotnet/aspnet-blazor-eng in general, any idea why BundlesScopedCssFiles_UpdatesBundleWhenContentsChange() is still executing in the main aspnetcore-ci pipeline❔ See #39303 (resolved; I was confused)

I'd also appreciate your thoughts on simply skipping this test in release/5.0. It's only about 30% successful and therefore isn't providing any value.

@dougbu
Copy link
Member

dougbu commented Jan 8, 2022

Reopening because I'm about to Skip this test in release/5.0. It's providing no value at the moment.

@dougbu dougbu reopened this Jan 8, 2022
@mkArtakMSFT mkArtakMSFT removed the Done This issue has been fixed label Jan 8, 2022
@mkArtakMSFT mkArtakMSFT removed this from the 5.0.0 milestone Jan 8, 2022
@mkArtakMSFT mkArtakMSFT added this to the 5.0.x milestone Jan 8, 2022
@javiercn
Copy link
Member

@mkArtakMSFT not sure what action you expect me to take here.

@mkArtakMSFT mkArtakMSFT modified the milestones: 5.0.x, .NET 7 Planning Jan 20, 2022
@mkArtakMSFT
Copy link
Member

@javiercn need to address the stability issue with this test. Let's target to do this in 7.0

@javiercn
Copy link
Member

@mkArtakMSFT this test is not flaky, the issue is from 2 years ago. I'm closing this as there's no action to be taken here

@javiercn javiercn removed this from the 7.0-preview1 milestone Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates test-failure
Projects
None yet
Development

No branches or pull requests

7 participants