Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing " in an @onclick attribute does not auto-insert an ending " #5075

Closed
NTaylorMullen opened this issue Oct 22, 2020 · 5 comments
Closed
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Contributor

GmkJYVdxCc

@NTaylorMullen
Copy link
Contributor Author

Putting in 16.9-P3 only to forward to platform to properly fix.

@NTaylorMullen
Copy link
Contributor Author

Note: This is 99% chance external. The goal here is to gather enough information so we can file a bug on the CoreEditor so they know what's going on Etienne will be a good point of contact for this.

@allisonchou
Copy link
Contributor

allisonchou commented Jan 19, 2021

EDIT: Turns out this may be an Editor issue instead of a WebTools issue, so need to talk to Etienne first before proceeding.

From investigating, WebTools needs to add a new auto-completion case for " - filed and provided additional details at https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1267534.
Razor will also need to respond to these changes by adding support for " in our AutoInsertHandler. This should be a very minor change.

@allisonchou
Copy link
Contributor

So it looks like the "proper" solution (according to an email thread with Etienne) may actually be to support language-configuration.json's AutoClosingPair property, tracked by https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1086473/.

Unfortunately, there doesn't seem to be an ETA on when this task may be completed, but if this is a big user ask, we may want to ask the Editor team to prioritize it.

@NTaylorMullen
Copy link
Contributor Author

Awesome, thanks Allison! Feel free to close this issue out as "duplicate"

@ghost ghost locked as resolved and limited conversation to collaborators Feb 21, 2021
@ghost ghost unlocked this conversation Oct 8, 2021
@allisonchou allisonchou transferred this issue from dotnet/aspnetcore Oct 8, 2021
@allisonchou allisonchou added this to the 16.9-Preview4 milestone Oct 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants