Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeartbeatSlow trace is called with incorrect arguments order #28660

Closed
mariopasquali opened this issue Dec 15, 2020 · 2 comments
Closed

HeartbeatSlow trace is called with incorrect arguments order #28660

mariopasquali opened this issue Dec 15, 2020 · 2 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue
Milestone

Comments

@mariopasquali
Copy link

Describe the bug

I get the following log line:

Kestrel: As of "00:00:02.3507376", the heartbeat has been running for "00:00:01" which is longer than "12/15/2020 07:02:37 +00:00". This could be caused by thread pool starvation.

The order of the arguments is incorrect.

In file src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelTrace.cs:

        private static readonly Action<ILogger, TimeSpan, TimeSpan, DateTimeOffset, Exception?> _heartbeatSlow =
            LoggerMessage.Define<TimeSpan, TimeSpan, DateTimeOffset>(LogLevel.Warning, new EventId(22, "HeartbeatSlow"), @"As of ""{now}"", the heartbeat has been running for ""{heartbeatDuration}"" which is longer than ""{interval}"". This could be caused by thread pool starvation.");

is defined with order "now, heartbeatDuration, interval"

        public virtual void HeartbeatSlow(TimeSpan heartbeatDuration, TimeSpan interval, DateTimeOffset now)
        {
            _heartbeatSlow(_logger, heartbeatDuration, interval, now, null);
        }

is invoked with order "heartbeatDuration, interval, now"

@BrennanConroy BrennanConroy added good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue labels Dec 16, 2020
@BrennanConroy BrennanConroy added this to the Next sprint planning milestone Dec 16, 2020
@ghost
Copy link

ghost commented Dec 16, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@BrennanConroy
Copy link
Member

Done via #28698

@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue
Projects
None yet
Development

No branches or pull requests

5 participants
@pranavkm @BrennanConroy @amcasey @mariopasquali and others