We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider:
public CookiePolicyMiddleware(RequestDelegate next, IOptions<CookiePolicyOptions> options) { Options = options.Value; _next = next; _logger = NullLogger.Instance; } public CookiePolicyMiddleware(RequestDelegate next, IOptions<CookiePolicyOptions> options, ILoggerFactory factory) { Options = options.Value; _next = next ?? throw new ArgumentNullException(nameof(next)); _logger = factory.CreateLogger<CookiePolicyMiddleware>(); }
This class is activated by UseMiddleware which calls Activator.CreateInstance. https://github.com/aspnet/HttpAbstractions/blob/9119433ab778d7adf04c4601917809f2f4582a93/src/Microsoft.AspNetCore.Http.Abstractions/Extensions/UseMiddlewareExtensions.cs#L92
The shorter constructor is being used by default and logging doesn't work. Either constructor works if I comment out the other.
Our breaking change policy requires adding new constructors when adding new parameters.
The text was updated successfully, but these errors were encountered:
Likely a dup of #2871.
Sorry, something went wrong.
No branches or pull requests
Consider:
This class is activated by UseMiddleware which calls Activator.CreateInstance.
https://github.com/aspnet/HttpAbstractions/blob/9119433ab778d7adf04c4601917809f2f4582a93/src/Microsoft.AspNetCore.Http.Abstractions/Extensions/UseMiddlewareExtensions.cs#L92
The shorter constructor is being used by default and logging doesn't work. Either constructor works if I comment out the other.
Our breaking change policy requires adding new constructors when adding new parameters.
The text was updated successfully, but these errors were encountered: