Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razor source generator incrementality goes wrong on downgrades #30246

Closed
SteveSandersonMS opened this issue Feb 17, 2021 · 4 comments
Closed
Labels
area-razor.compiler This issue is related to the Razor compiler (now external) bug This issue describes a behavior which is not expected - a bug. feature-source-generators
Milestone

Comments

@SteveSandersonMS
Copy link
Member

This is to track fixing the issue identified at dotnet/sdk#15756 (review)

The most likely case where this affects someone is when downgrading to an older dependency, but would also affect them when upgrading to one that's already cached locally.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@pranavkm pranavkm transferred this issue from dotnet/sdk Feb 17, 2021
@pranavkm
Copy link
Contributor

This should be a good way to track that the specific issue gets fixed. Also we're continuing to use the AspNetCore repo to track SDK issues, so moved this over.

@pranavkm pranavkm added the area-razor.compiler This issue is related to the Razor compiler (now external) label Feb 17, 2021
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Feb 17, 2021
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Feb 17, 2021
@ghost
Copy link

ghost commented Feb 17, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@captainsafia
Copy link
Member

Closing this in favor of #30234.

We're moving to an in-memory cache model which will remove this particular codepath. Instead, we'll be determining whether or not to cache-bust based on a unique identifier associated with each metadata reference.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-razor.compiler This issue is related to the Razor compiler (now external) bug This issue describes a behavior which is not expected - a bug. feature-source-generators
Projects
None yet
Development

No branches or pull requests

4 participants