Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kestrel does not send "100 Continue" when MinRequestBodyDataRate is null #30449

Closed
halter73 opened this issue Feb 25, 2021 · 1 comment
Closed

Kestrel does not send "100 Continue" when MinRequestBodyDataRate is null #30449

halter73 opened this issue Feb 25, 2021 · 1 comment
Assignees
@halter73
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions bug This issue describes a behavior which is not expected - a bug. feature-kestrel
Milestone
3.1.x

Comments

@halter73
Copy link
Member

halter73 commented Feb 25, 2021 •
edited
Loading

Kestrel does not send "100 Continue" when MinRequestBodyDataRate is null. TryProduceContinue should still be called even if _timingEnabled is false in the following logic:

aspnetcore/src/Servers/Kestrel/Core/src/Internal/Http/MessageBody.cs

Lines 185 to 187 in 8df6490

if (!readAwaitable.IsCompleted && _timingEnabled)
{
TryProduceContinue();

The fix will need to be backported to release/3.1.
@davidfowl davidfowl added bug This issue describes a behavior which is not expected - a bug. area-servers labels Feb 25, 2021
@BrennanConroy BrennanConroy mentioned this issue Feb 26, 2021
Closed
@BrennanConroy BrennanConroy added this to the 3.1.x milestone Feb 26, 2021
@halter73 halter73 mentioned this issue Mar 26, 2021
Merged
@halter73 halter73 mentioned this issue Apr 6, 2021
Merged
@halter73 halter73 removed the Working label Jul 14, 2021
@halter73
Copy link
Member Author

Fixed by #31284

@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@halter73 halter73

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions bug This issue describes a behavior which is not expected - a bug. feature-kestrel
Projects
None yet
Milestone
3.1.x
Development

No branches or pull requests
4 participants
@halter73 @davidfowl @BrennanConroy @amcasey