Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AspNetCore to use MetadataUpdateHandlerAttribute to clear caches #31806

Closed
3 tasks
pranavkm opened this issue Apr 14, 2021 · 4 comments
Closed
3 tasks
Labels
area-blazor Includes: Blazor, Razor Components feature-hot-reload This issue is related to the Hot Reload feaature feature-routing
Milestone

Comments

@pranavkm
Copy link
Contributor

  • Blazor re-rendering
  • Blazor Routing
  • ASP.NET Core's routing

The last two bits are currently blocked since they're treated as rude edits

@pranavkm pranavkm added the area-blazor Includes: Blazor, Razor Components label Apr 14, 2021
@pranavkm pranavkm added this to the Next sprint planning milestone Apr 14, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@davidfowl
Copy link
Member

I assume for routing we can trigger a change token and be done

@pranavkm
Copy link
Contributor Author

Yup that's the plan. Routing is still a bit busted because changing custom attributes is currently treated as rude edit, but that is expected to be allowed soon-ish.

@javiercn javiercn added feature-routing feature-hot-reload This issue is related to the Hot Reload feaature labels Apr 20, 2021
@pranavkm
Copy link
Contributor Author

This is done. There's some additional cache clearing we need to do as part of the reloadable type effort, but that is being tracked separately.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components feature-hot-reload This issue is related to the Hot Reload feaature feature-routing
Projects
None yet
Development

No branches or pull requests

4 participants
@davidfowl @pranavkm @javiercn and others