Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detecting when attributes are put on a method called by a lambda instead of the lambda itself #35638

Closed
Tracked by #35528
captainsafia opened this issue Aug 23, 2021 · 0 comments · Fixed by #35779
Closed
Tracked by #35528

Detecting when attributes are put on a method called by a lambda instead of the lambda itself #35638

captainsafia opened this issue Aug 23, 2021 · 0 comments · Fixed by #35779
Assignees
@captainsafia
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-actions Controller-like actions for endpoint routing old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels Priority:2 Work that is important, but not critical for the release
Milestone
6.0-rc2

Comments

@captainsafia
Copy link
Member

captainsafia commented Aug 23, 2021 •
edited by davidfowl
Loading 

app.Map("/", () => Hello());
[Authorize]
void Hello() { }

should produce an analyzer warning
@captainsafia captainsafia mentioned this issue Aug 23, 2021
Closed
4 tasks
@captainsafia captainsafia changed the title Detecting when attributes are put on a method called by a lambda instead of the lambda itself:app.Map("/", () => Hello());[Authorize]void Hello() { } Hello());[Authorize]void Hello() { }" tabindex="0" role="button"> Detecting when attributes are put on a method called by a lambda instead of the lambda itself Aug 23, 2021
@captainsafia captainsafia added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels feature-minimal-actions Controller-like actions for endpoint routing labels Aug 23, 2021
@captainsafia captainsafia added this to the 6.0-rc2 milestone Aug 23, 2021
@captainsafia captainsafia self-assigned this Aug 26, 2021
@captainsafia captainsafia mentioned this issue Aug 26, 2021
Merged
@rafikiassumani-msft rafikiassumani-msft added the Priority:2 Work that is important, but not critical for the release label Aug 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2021
@amcasey amcasey added the area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc label Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@captainsafia captainsafia

Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-actions Controller-like actions for endpoint routing old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
6.0-rc2
Development

Successfully merging a pull request may close this issue.

Add analyzer for detecting misplaced attributes on delegates dotnet/aspnetcore
3 participants
@captainsafia @amcasey @rafikiassumani-msft