Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler crashing issues reported through internal telemetry #38879

Closed
mkArtakMSFT opened this issue Dec 7, 2021 · 5 comments
Closed

Compiler crashing issues reported through internal telemetry #38879

mkArtakMSFT opened this issue Dec 7, 2021 · 5 comments
Labels
area-razor.compiler This issue is related to the Razor compiler (now external) bug This issue describes a behavior which is not expected - a bug. Priority:1 Work that is critical for the release, but we could probably ship without razor.compiler-toolingsupport

Comments

@mkArtakMSFT
Copy link
Member

Internal Error - System.NullReferenceException: 개체 참조가 개체의 인스턴스로 설정되지 않았습니다. 위치: Microsoft.AspNetCore.Razor.Language.DefaultRazorTagHelperBinderPhase.ComponentDirectiveVisitor.TrySplitNamespaceAndType(StringSegment fullTypeName, StringSegment& namespace, StringSegment& typeName) 위치: Microsoft.AspNetCore.Razor.Language.DefaultRazorTagHelperBinderPhase.ComponentDirectiveVisitor.IsTagHelperFromMangledClass(TagHelperDescriptor tagHelper) 위치: Microsoft.AspNetCore.Razor.Language.DefaultRazorTagHelperBinderPhase.ComponentDirectiveVisitor..ctor(String filePath, IReadOnlyList`1 tagHelpers, String currentNamespace) -- Another compiler error same as above

More context can be found from: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1435565

@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. area-razor.compiler This issue is related to the Razor compiler (now external) razor.compiler-toolingsupport Priority:1 Work that is critical for the release, but we could probably ship without labels Dec 7, 2021
@mkArtakMSFT mkArtakMSFT added this to the .NET 7 Planning milestone Dec 7, 2021
@ghost
Copy link

ghost commented Dec 7, 2021

Thanks for contacting us.

We're moving this issue to the .NET 7 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@javiercn
Copy link
Member

I have a PR out for this issue, but its unclear how it can manifest itself.

In any case, I replaced the code we use for parsing with the equivalent Roslyn API to discard any "dubious parsing logic" being the source of this issue.

@TanayParikh
Copy link
Contributor

@javiercn
Copy link
Member

javiercn commented Feb 9, 2022

We are investigating the underlying cause of this issue as we are seeing some strange behavior going on from the dumps.

@javiercn
Copy link
Member

Fixed on ca1728b83851de4211477ab37a2460bf567544d3

@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-razor.compiler This issue is related to the Razor compiler (now external) bug This issue describes a behavior which is not expected - a bug. Priority:1 Work that is critical for the release, but we could probably ship without razor.compiler-toolingsupport
Projects
None yet
Development

No branches or pull requests

3 participants