-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Build template packages in servicing #40637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@MichaelSimons thanks for bringing this up to our attention. @dotnet/aspnet-build do you know what might be going on here? |
The template packages do get built in servicing builds, see the |
@wtgodbe, Thanks for pointing that out. They aren't getting built in source-build - https://dev.azure.com/dnceng/_apis/resources/Containers/9800566/PackageArtifacts?itemPath=PackageArtifacts%2FMicrosoft.SourceBuild.Intermediate.aspnetcore.6.0.4-servicing.22159.2.nupkg. Is this something you can help address? |
Ah, sorry for the confusion - we exclude everything except the targeting pack & SharedFx (which bring in all other |
Getting this fixed in main and release/6.0 is sufficient. Thanks. |
Currently building release/6.0 doesn't produce the template packages.
Microsoft.DotNet.Web.ItemTemplates
Microsoft.DotNet.Web.ProjectTemplates
Microsoft.DotNet.Web.Spa.ProjectTemplates
This doesn't work well for .NET source-build which needs to product the entire product for every build (e.g. previews, rtm, servicing, etc).
Would it be amenable to always produce the template packages during servicing builds? An alternative less desirable option would be to build them only in source-build.
Currently source-build treats these packages as text-only packages that are checked in/reverse engineered. This solution is not ideal as it requires manual updates, is a maintenance burden, and in general is problematic.
This issue is similar in nature to #39471 and dotnet/templating#4337.
The text was updated successfully, but these errors were encountered: