Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support O DateTime(Offset) format in dotnet user-jwts tool #41973

Closed
1 task done
Tracked by #34545
martincostello opened this issue Jun 1, 2022 · 1 comment · Fixed by #42125
Closed
1 task done
Tracked by #34545

Support O DateTime(Offset) format in dotnet user-jwts tool #41973

martincostello opened this issue Jun 1, 2022 · 1 comment · Fixed by #42125
Assignees
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Milestone

Comments

@martincostello
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

When using the new dotnet user-jwts tool, users may paste formatted date times in from other sources (e.g. decoding another existing JWT using something like jwt.io).

Describe the solution you'd like

To make copy-paste in these scenarios, supporting the "O" format would make the tool more user-friendly.

The tool already supports 4 different possible formats:

"yyyy-MM-dd", "yyyy-MM-dd HH:mm", "yyyy/MM/dd", "yyyy/MM/dd HH:mm" };

It displays the values in "O" format from the list command, so would support round-tripping when decoded.

if (showTokens)
{
table.AddRow(jwt.Id, jwt.Scheme, jwt.Audience, jwt.Issued.ToString("O"), jwt.Expires.ToString("O"), jwt.Token);
}
else
{
table.AddRow(jwt.Id, jwt.Scheme, jwt.Audience, jwt.Issued.ToString("O"), jwt.Expires.ToString("O"));
}

Additional context

See #41956 (comment).

/cc @DamianEdwards

@TanayParikh TanayParikh added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jun 1, 2022
@captainsafia captainsafia self-assigned this Jun 3, 2022
@Tratcher Tratcher added this to the .NET 7 Planning milestone Jun 3, 2022
@ghost
Copy link

ghost commented Jun 3, 2022

Thanks for contacting us.

We're moving this issue to the .NET 7 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants