Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-jwts should just create the UserSecretsId if not found #41975

Closed
1 task done
timheuer opened this issue Jun 1, 2022 · 1 comment · Fixed by #42006
Closed
1 task done

user-jwts should just create the UserSecretsId if not found #41975

timheuer opened this issue Jun 1, 2022 · 1 comment · Fixed by #42006
Assignees
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Milestone

Comments

@timheuer
Copy link
Member

timheuer commented Jun 1, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When using dotnet user-jwts create if there is no UserSecretsId it will fail saying one is not found. We should either:

  • (Preferred) Generate the UserSecretsId for the user...this is non-impacting for the code and creates a delighter to complete the task fully that I asked it to do (show in output 'user secrets not found, generated [guid]' before adding the newly created token
  • Clarify what to do in the event UserSecretsId is not there (IMO, not an awesome experience to use a separate tool)

#41956 (comment)

Expected Behavior

The token is just created for me, doing what is needed to create the secrets/file association if not found.

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

@TanayParikh TanayParikh added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jun 1, 2022
@adityamandaleeka
Copy link
Member

@captainsafia, assigning this to you since it's follow-up from the user-jwts work.

@captainsafia captainsafia added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Jun 2, 2022
@rafikiassumani-msft rafikiassumani-msft added this to the 7.0-preview6 milestone Jun 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants