-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Blazor WASM Template tests are too long #42406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
An example where it hit the 40 minute timeout today |
The issue seems to be particularly acute on I'm planning on looking into this in the RC1 timeframe to figure out how we can shorten the run-times overall. |
Kusto says these work items run far longer than other template tests over the last 2 weeks. Rebalancing tests between projects may be enough.
QueryJobs
| where Queued > ago(14d)
and Repository == "dotnet/aspnetcore"
and Branch == "refs/heads/main"
and Properties has "aspnetcore-ci"
| join kind=inner WorkItems on JobId
| where FriendlyName has "Templates" and FailCount == 0 and PassOnRetryCount == 0
| project FriendlyName, QueueName, QueueAlias, Duration = Finished1 - Started1
| summarize format_timespan(min(Duration), 'hh:mm:ss'),
format_timespan(max(Duration), 'hh:mm:ss')
by FriendlyName, QueueName
| sort by FriendlyName asc, QueueName asc |
Recently, there have been several new tests in the space:
I wonder if we can track the increased execution times to those tests. It's a bit odd WASM specifically takes so long... |
@TanayParikh only #42420 went in after #42382. We could probably look at data for the WASM work items since 23 June (when #42382 went in) by date. @DamianEdwards might already have the right query 😀 |
This is in line with Doug's table above where the Server tests are pretty quick:
Created #42879 to split out the auth tests which seems like a pretty clear "split line" for the Blazor WASM Tests. |
The Templates.Blazor.WebAssembly.Tests project is taking 37+ minutes on Helix. This is dangerously close to the 40 minute timeout we have on Helix and in fact the tests were hitting this timeout before we split the Blazor.Server parts out into it's own project in: #42382. Unfortunately this only saved ~4.5 minutes.
I suggest the Blazor team takes a look at this test project and either trims down the test variants, or splits the project up even further to reduce the time each test leg takes.
The text was updated successfully, but these errors were encountered: