Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickGrid documentation insufficiency #44446

Closed
1 task done
NikolayRenziglov opened this issue Oct 10, 2022 · 15 comments
Closed
1 task done

QuickGrid documentation insufficiency #44446

NikolayRenziglov opened this issue Oct 10, 2022 · 15 comments
Assignees
Labels
area-blazor Includes: Blazor, Razor Components Docs This issue tracks updating documentation feature-blazor-quickgrid
Milestone

Comments

@NikolayRenziglov
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

The QuickGrid documentation has no info about adding the dynamic column from the C# code.

Describe the solution you'd like

Please add the documentation or provide a link if it exists to the way one can add the dynamic Template or Property column to the QuickGrid.

Additional context

No response

@TanayParikh TanayParikh added the area-blazor Includes: Blazor, Razor Components label Oct 10, 2022
@danroth27 danroth27 added the Docs This issue tracks updating documentation label Oct 10, 2022
@danroth27 danroth27 added this to the 8.0-MQ milestone Oct 10, 2022
@guardrex
Copy link
Contributor

guardrex commented Oct 10, 2022

This content is currently located at ...

https://learn.microsoft.com/en-us/aspnet/core/blazor/components/?view=aspnetcore-7.0#quickgrid-component

I'm merely noting this for updates to the doc based on the product unit's feedback here and to keep an 👁️ on this issue. Note that the milestone is 8.0-MQ, which means that this will likely be reached after 7.0 releases (planned for November).

@NikolayRenziglov
Copy link
Author

Hi there. Thanks for a prompt postback. The reason I posed that question is the lack of documentation on how to add a dynamic fields in C# code. Should it be something like
RenderFragment columns = b => { b.OpenComponent(1, typeof(TemplateColumn<MyItemType>)); b.AddMarkupContent(1,"<p>YOYOY</p>"); b.CloseComponent(); }; ?
Any brief example would be helpful. Sincerely

@mkArtakMSFT
Copy link
Member

@guardrex we're trying to bring the QuickGrid productization work to 8.0-preview2. As soon as that's done, I'll ping you here to finish the documentation work for it.

@mkArtakMSFT
Copy link
Member

@guardrex the change just got merged to preview2. Feel free to publish your docs when preview2 ships.

@guardrex
Copy link
Contributor

guardrex commented Mar 4, 2023

@mkArtakMSFT ... We still don't have the 8.0 docs in the doc version selector. I can address the content now for the preview 2 release, but nobody will ever see it until "8.0" is activated for view. @Rick-Anderson ... About when does that happen each year? I don't pay too much attention to when it happens ... I 🎷🎶 jam along until it just ✨ Magically Appears™ ✨😄.

Also, @mkArtakMSFT ... The ask here is for updated docs on features of QuickGrid ...

no info about adding the dynamic column from the C# code

... not just about it rolling into the framework for 8.0. It looks like from the blog post at https://devblogs.microsoft.com/dotnet/asp-net-core-updates-in-dotnet-8-preview-1/ that new features weren't added for preview 1.

Which of these should I pursue ...

  1. Merely update the language to indicate that the package is in the framework for 8.0.
  2. Do that ☝️ and look at PU PRs and document its new features for 8.0.

@Rick-Anderson
Copy link
Contributor

@mkArtakMSFT ... We still don't have the 8.0 docs in the doc version selector.

Publish some 8.0 content and if it's not activated I'll get that fixed. It's supposed to be active but I'm skeptical as I don't see in on the live site, but it's visible on the internal build site.

@guardrex
Copy link
Contributor

guardrex commented Mar 6, 2023

I put some up three weeks ago in a Blazor Hybrid doc ...

https://github.com/dotnet/AspNetCore.Docs/blame/main/aspnetcore/blazor/hybrid/routing.md#L228

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Mar 6, 2023

https://learn.microsoft.com/en-us/aspnet/core/blazor/hybrid/routing?view=aspnetcore-8.0&pivots=maui#deep-linking

Internal work item URL

Hopefully this will be fixed in a few days. I gave them your 8.0 content to test. BTW, you can see the 8.0 content by hacking the URL like I did, but then you can't select other versions.

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Mar 7, 2023

@guardrex production is working now. I think I'll open another work item to make it say pre-release

@guardrex
Copy link
Contributor

guardrex commented Mar 7, 2023

Thanks ... it indicates it after "8.0" is selected ...

image

@Rick-Anderson
Copy link
Contributor

Thanks ... it indicates it after "8.0" is selected ...

It wasn't until I opened a new issue. Glad it's fixed.

@mkArtakMSFT
Copy link
Member

  1. Merely update the language to indicate that the package is in the framework for 8.0.

This @guardrex !
You're right, we haven't added new features yet.

@guardrex
Copy link
Contributor

guardrex commented Mar 8, 2023

Thanks @mkArtakMSFT ... I'll take care of it by EOD.

@mkArtakMSFT
Copy link
Member

@guardrex should this be closed now?

@guardrex
Copy link
Contributor

guardrex commented Mar 14, 2023

Yes, I'll track on QuickGrid feature updates separately on my docs tracking issue. The coverage on it being in the framework is live now at ...

https://learn.microsoft.com/en-us/aspnet/core/blazor/components/?view=aspnetcore-8.0#quickgrid-component

@ghost ghost locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components Docs This issue tracks updating documentation feature-blazor-quickgrid
Projects
None yet
Development

No branches or pull requests

8 participants