Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor Hot Reload generic #46100

Closed
1 task done
timeshift92 opened this issue Jan 14, 2023 · 6 comments
Closed
1 task done

Blazor Hot Reload generic #46100

timeshift92 opened this issue Jan 14, 2023 · 6 comments
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external) feature-hot-reload This issue is related to the Hot Reload feaature

Comments

@timeshift92
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

hello hotreload current doesn't work with generic for example

<MudTextField Label="First name" HelperText="Max. 8 characters"
                              @bind-Value="model.Username" For="@(() => model.Username)"/>

if i remove this code i need to relaod full project

Describe the solution you'd like

i don't know =(

Additional context

No response

@TanayParikh TanayParikh added area-blazor Includes: Blazor, Razor Components feature-hot-reload This issue is related to the Hot Reload feaature labels Jan 14, 2023
@javiercn javiercn added area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external) labels Jan 14, 2023
@javiercn
Copy link
Member

@timeshift92 thanks for contacting us.

if i remove this code i need to relaod full project

Do you mean that hot-reload breaks and you have to reload the project manually or just that it automatically reloads the whole page instead of just the component.

Could you provide a minimal repro project as a public github repository so that we can take a look at the concrete problem you are running into?

@tmat can you take a look?

@javiercn javiercn removed the area-blazor Includes: Blazor, Razor Components label Jan 16, 2023
@timeshift92
Copy link
Author

yes one moment
image

@timeshift92
Copy link
Author

BlazorMud.zip

@timeshift92
Copy link
Author

@tmat
Copy link
Member

tmat commented Jan 17, 2023

Thanks for the repro.

The edit is blocked because it updates a generated generic method, which is not supported on .NET 7:

image

I have filed dotnet/runtime#80749 on the runtime to add support.

@danroth27 @mkArtakMSFT @tommcdon @maddymontaquila
FYI

@danroth27
Copy link
Member

Closing as hot reload support for generics is being tracked by dotnet/runtime#80749.

@timeshift92 timeshift92 changed the title Blazor Hotrelopad generic Blazor Hotreload generic Jan 18, 2023
@timeshift92 timeshift92 changed the title Blazor Hotreload generic Blazor Hot Reload generic Jan 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external) feature-hot-reload This issue is related to the Hot Reload feaature
Projects
None yet
Development

No branches or pull requests

5 participants