Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If InvariantGlobalization is enabled by default, SqlClient will throw an exception #48186

Closed
Varorbc opened this issue May 11, 2023 · 6 comments
Assignees
Labels
External This is an issue in a component not contained in this repository. It is open for tracking purposes. NativeAOT Status: Resolved
Milestone

Comments

@Varorbc
Copy link
Contributor

Varorbc commented May 11, 2023

Most applications will use EFCore or SqlCilent, and if InvariantGlobalization is enabled by default, SqlClient will throw an exception, although it is easy to remove InvariantGlobalization, But it always leaves users wondering

Originally posted by @Varorbc in #47066 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label May 11, 2023
@mitchdenny
Copy link
Member

What is the exception that is being thrown?

@Varorbc
Copy link
Contributor Author

Varorbc commented May 15, 2023

@mitchdenny
Copy link
Member

OK, there isn't really anything for us to do here since this behavior in SqlClient appears to be by design.

@mitchdenny mitchdenny added the ✔️ Resolution: By Design Resolved because the behavior in this issue is the intended design. label May 15, 2023
@ghost ghost added the Status: Resolved label May 15, 2023
@Varorbc
Copy link
Contributor Author

Varorbc commented May 15, 2023

As I mentioned before, most applications will use EFCore or SqlClient. If both sides are designed for this purpose, exceptions will occur when used together. Can the two teams communicate to solve this issue?

@mitchdenny
Copy link
Member

OK, I think the compromise position here could be to disable invariant mode when the project is created with out the --aot switch. The recent change we made here was really targeting native AOT scenarios where we might be willing to have people have to opt themselves out of invariant culture if they want to use SqlClient.

@mitchdenny mitchdenny self-assigned this May 15, 2023
@mitchdenny mitchdenny removed the ✔️ Resolution: By Design Resolved because the behavior in this issue is the intended design. label May 15, 2023
@mitchdenny mitchdenny added this to the 8.0-preview5 milestone May 15, 2023
@mkArtakMSFT mkArtakMSFT added External This is an issue in a component not contained in this repository. It is open for tracking purposes. and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels May 16, 2023
@ghost
Copy link

ghost commented May 17, 2023

This issue has been resolved and has not had any activity for 1 day. It will be closed for housekeeping purposes.

See our Issue Management Policies for more information.

@ghost ghost closed this as completed May 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
External This is an issue in a component not contained in this repository. It is open for tracking purposes. NativeAOT Status: Resolved
Projects
None yet
Development

No branches or pull requests

4 participants