Provide hooks to allow for integration with other JavaScript frameworks

[elanderson]

I am looking into creating a Vue template that works with the Vue CLI. Similar to what was done with the provided Angular and React templates.

Following the path of UseReactDevelopmentSever I was able to get an example up and running, but to do so I ended up copying and pasting about 6 class from this repo that are marked as internal. All of the added classes came in when I got to the point to converting StartCreateReactAppServerAsync.

Would it be possible to add new hooks to making interation with other framework easier or make the existing classes public?

For reference the classes I had to import were:

• EventedStreamStringReader
• LoggerFinder
• NpmScriptRunner
• TaskTimeoutExtensions
• TcpPortFinder

While none of these classes are huge it would be nice to not have to manually keep them in sync with changes in this repo.

[SteveSandersonMS]

This makes sense - thanks for the suggestion.

Currently it's not something on our backlog, but CC @glennc for planning purposes in case this changes. Edit: also @danroth27, another PM.

[elanderson]

@SteveSandersonMS would this be something I could submit a PR for? I would be happy to play around with it a bit if the team would have time to review it.

[SteveSandersonMS]

It's not really something we're looking for a PR for, because the cost isn't implementing the change (we can implement it trivially).

The cost is going through an API review process and committing to support those APIs for the long term. So it's a strategy decision to be made.

[elanderson]

Understood. Thanks for the consideration!

[EEParker]

@elanderson I went through the same process for Vue + vue-cli and my solution ended up being nearly identical to the react development server. The only change I made was to the regex to detect if the server was running here: https://github.com/aspnet/JavaScriptServices/blob/dev/src/Microsoft.AspNetCore.SpaServices.Extensions/ReactDevelopmentServer/ReactDevelopmentServerMiddleware.cs#L87

@SteveSandersonMS Perhaps this regex could be changed to something that more frameworks support? I noticed in some previous versions it was new Regex("Local:\\s*(http\\S+)", RegexOptions.None, RegexMatchTimeout), which does work for Vue. Ref: aspnet/JavaScriptServices@68c4620#diff-6b9344cdb73193920e8ee7888a4095c6L74

[elanderson]

@EEParker that was my experience as well. There would also be some strings for logging and exceptions that would need to change, but the core is the regex you mentioned.

[valeriob]

i've come up with the same solution as @EEParker, my working pull request is here aspnet/JavaScriptServices#1713

[buldo]

I also have solution for this issue in this PR #1736

[ascott18]

Now that Visual Studio 15.8 is RTM with support for .vue SFCs, any chance we could get some traction here for supporting vue-cli based projects officially? @vue/cli is also RTM now, too.

[mkArtakMSFT]

Thanks for contacting us, @elanderson.
This is not something we plan to do in the near future.

[mkArtakMSFT]

Reopening this as we plan to enable better integration with SPA frameworks in 5.0. You can see more details about this plan here.

[mkArtakMSFT]

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

[javiercn]

@elanderson thanks for contacting us.

We've significantly changed the way the SPA templates are setup for development and production to align with how other backend frameworks approach this and as a result we no longer use SpaServices as part of the development workflow.

While we haven't removed or obsoleted the code, we don't plan to make future changes/fixes on it and we recommend people migrate to the new approach we use in the templates.

This approach is agnostic to the front-end SPA framework being used and should allow integration with any SPA framework available.