Skip to content

Changes to IdentityApiEndpointRouteBuilderExtensions made get api/User/manage/info pointless #52311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
nazare2020 opened this issue Nov 22, 2023 · 2 comments
Closed
1 task done
Assignees
Labels
area-identity Includes: Identity and providers enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@nazare2020
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

#51177

This has made /api/User/manage/info return the same info you send in the body of the request

return TypedResults.Ok(await CreateInfoResponseAsync(user, userManager));

return new() { Email = await userManager.GetEmailAsync(user) ?? throw new NotSupportedException("Users must have an email."), IsEmailConfirmed = await userManager.IsEmailConfirmedAsync(user), };
Already a breaking change going from 'account' to 'manage' so might as well have got rid of the call

Expected Behavior

Ideally it would still return some info on the user i.e. UserId etc

Steps To Reproduce

call /api/User/manage/info with email and isEmailConfirmed values. Get the same back.

Exceptions (if any)

No response

.NET Version

8.0.100

Anything else?

No response

@ghost ghost added the area-identity Includes: Identity and providers label Nov 22, 2023
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@MackinnonBuck MackinnonBuck added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Feb 7, 2024
@MackinnonBuck MackinnonBuck added this to the .NET 9 Planning milestone Feb 7, 2024
@MackinnonBuck
Copy link
Member

Could share an abstraction with #52769 to determine which claims to serialize.

@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@mikekistler
Copy link
Contributor

This should be handled with #58959 -- closing.

@mikekistler mikekistler closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests

6 participants