Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignalR .NET client telemetry #53429

Open
1 task done
JamesNK opened this issue Jan 17, 2024 · 4 comments
Open
1 task done

SignalR .NET client telemetry #53429

JamesNK opened this issue Jan 17, 2024 · 4 comments
Labels
area-signalr Includes: SignalR clients and servers

Comments

@JamesNK
Copy link
Member

JamesNK commented Jan 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

The SignalR .NET client doesn't have telemetry. This is a gap compared to .NET clients for HTTP and RPC. HttpClient and GrpcChannel have metrics and activities for tracking usage.

Describe the solution you'd like

SignalR .NET client should have metrics:

  • Conenction-level metrics. This would be similar to the metrics offered on the server.
  • Invocation-level metrics. e.g. current active invocations, invocation duration

And it should create an activity for invocations so they show up in tracing.

Additional context

No response

@JamesNK JamesNK added the area-signalr Includes: SignalR clients and servers label Jan 17, 2024
@BrennanConroy
Copy link
Member

And it should create an activity for invocations so they show up in tracing.

Tracked by #51557

SignalR .NET client should have metrics:

Tracked by #2461
If you have specific ones add them to the issue.

@JamesNK
Copy link
Member Author

JamesNK commented Jan 18, 2024

I made this issue because so far all the discussion I've seen is about server improvements. It can be closed if the other metrics and tracing issues cover both client and server.

@adityamandaleeka
Copy link
Member

I suggest moving any client-specific stuff from #2461 to here and closing that one. That issue is long and largely stale.

@adityamandaleeka adityamandaleeka added this to the .NET 9 Planning milestone Jan 31, 2024
@ghost
Copy link

ghost commented Jan 31, 2024

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

No branches or pull requests

3 participants