-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Published size regression: basicminimalapipublishaot, basicminimalapipublishaot, todosapipublishaot #55789
Comments
This appears to be caused by #55558. Specifically by the usage of System.Linq over value types (in this case System.Double). Comparing the before and after: You can see that there is 53.5 kB of System.Linq code in the new code. Expanding this: And then seeing what is bringing that code in shows: Which points to: aspnetcore/src/Http/Routing/src/Matching/NegotiationMatcherPolicy.cs Lines 287 to 290 in 94ad1d4
If we would eliminate the usage of System.Linq here, we would go back to (roughly) the size before the change. cc @javiercn |
Attached is the mstat and dgml files that can be opened with https://github.com/MichalStrehovsky/sizoscope to see the above information. |
Should we consider not including this matcher at all in the slim builder? |
@DamianEdwards fixed as part of #56045 |
Changes
9.0.0-preview.5.24256.2
->9.0.0-preview.5.24266.2
9.0.0-preview.5.24256.1
->9.0.0-preview.5.24265.2
Changes
9.0.0-preview.5.24256.2
->9.0.0-preview.5.24266.2
9.0.0-preview.5.24256.1
->9.0.0-preview.5.24265.2
Changes
9.0.0-preview.5.24256.2
->9.0.0-preview.5.24266.2
9.0.0-preview.5.24256.1
->9.0.0-preview.5.24265.2
PowerBI Dashboard
@sebastienros
@eerhardt
The text was updated successfully, but these errors were encountered: