Skip to content

Test failure: no exception in ResultsOfTResult1TResult2_Throws_InvalidOperationException_WhenResultIsNull #57360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akoeplinger opened this issue Aug 16, 2024 · 0 comments · Fixed by #57465
Closed

Test failure: no exception in ResultsOfTResult1TResult2_Throws_InvalidOperationException_WhenResultIsNull #57360

akoeplinger opened this issue Aug 16, 2024 · 0 comments · Fixed by #57465
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
Milestone
10.0-preview1

Comments

@akoeplinger
Copy link
Member

While looking at #57303 I discovered the ResultsOfTResult1TResult2_Throws_InvalidOperationException_WhenResultIsNull and other related tests from src/Http/Http.Results/test/ResultsOfTTests.Generated.cs don't actually throw an InvalidOperationException, but no exception at all.

We didn't notice because we didn't await the Assert.ThrowsAsync.

Filing this issue for tracking.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Aug 16, 2024
@akoeplinger akoeplinger mentioned this issue Aug 16, 2024
Merged
@gfoidl gfoidl added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Aug 16, 2024
@captainsafia captainsafia added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Aug 22, 2024
@captainsafia captainsafia mentioned this issue Aug 22, 2024
Merged
@captainsafia captainsafia added this to the 10.0-preview1 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging a pull request may close this issue.

Fix ResultsOfTGenerated tests dotnet/aspnetcore
3 participants
@akoeplinger @captainsafia @gfoidl