Skip to content

[API Proposal]: PinnedBlockMemoryPool metrics #61594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrennanConroy opened this issue Apr 21, 2025 · 1 comment
Open

[API Proposal]: PinnedBlockMemoryPool metrics #61594

BrennanConroy opened this issue Apr 21, 2025 · 1 comment
Labels
api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Comments

@BrennanConroy
Copy link
Member

BrennanConroy commented Apr 21, 2025

Background and Motivation

Add metrics to the PinnedBlockMemoryPool that's used by Kestrel, IIS, and Http.Sys.

Proposed API

Microsoft.AspNetCore.MemoryPool

Name Instrument Type Unit Description
aspnetcore.memorypool.current_memory UpDownCounter {bytes} Number of bytes that are currently pooled by the pool.
Name Instrument Type Unit Description
aspnetcore.memorypool.total_allocated Counter {bytes} Total number of allocations made by the pool.
Name Instrument Type Unit Description
aspnetcore.memorypool.evicted_memory Counter {bytes} Total number of bytes that have been evicted.
Name Instrument Type Unit Description
aspnetcore.memorypool.total_rented Counter {bytes} Total number of rented bytes from the pool.
@BrennanConroy BrennanConroy added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Apr 21, 2025
@ghost ghost added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Apr 21, 2025
@BrennanConroy BrennanConroy added api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews and removed api-suggestion Early API idea and discussion, it is NOT ready for implementation needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Apr 21, 2025
Copy link
Contributor

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

  • The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
  • The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
  • Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

@gfoidl gfoidl added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

No branches or pull requests

2 participants