Skip to content

Update MVC template to use new Problem helpers in error handler #8538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DamianEdwards opened this issue Mar 14, 2019 · 5 comments
Open

Update MVC template to use new Problem helpers in error handler #8538

DamianEdwards opened this issue Mar 14, 2019 · 5 comments
Labels
affected-very-few This issue impacts very few customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-templates severity-nice-to-have This label is used by an internal tool
Milestone

Comments

@DamianEdwards
Copy link
Member

Relies on #8537

Update error handler action method to use new problem helper method #8537:

[Route("/error")]
public ActionResult<ProblemDetails> HandleError([FromHeader] string accept)
{
    if (accept.Contains("text/html"))
    {
        return View("Error", new ErrorViewModel { RequestId = Activity.Current?.Id ?? HttpContext.TraceIdentifier });
    }
 
    return Problem();
}
@DamianEdwards DamianEdwards added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 14, 2019
@mkArtakMSFT
Copy link
Contributor

Moving this to a future milestone so that we can address this after we'll finalize the templates.

@mkArtakMSFT mkArtakMSFT added 1 - Ready enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Mar 21, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview6 milestone Mar 21, 2019
@ryanbrandenburg ryanbrandenburg added the blocked The work on this issue is blocked due to some dependency label Jun 26, 2019
@ryanbrandenburg
Copy link
Contributor

Blocked by #8537.

@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview9, 3.1.0 Jul 31, 2019
@pranavkm pranavkm removed the blocked The work on this issue is blocked due to some dependency label Aug 5, 2019
@pranavkm
Copy link
Contributor

pranavkm commented Aug 5, 2019

This should be unblocked now.

@mkArtakMSFT
Copy link
Contributor

Moving this to 5.0 after a discussion with @glennc and @pranavkm.

@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview9, 5.0.0 Aug 14, 2019
@mkArtakMSFT mkArtakMSFT removed this from the 5.0.0 milestone Jan 21, 2020
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Jan 21, 2020
@mkArtakMSFT
Copy link
Contributor

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@javiercn javiercn added affected-very-few This issue impacts very few customers severity-nice-to-have This label is used by an internal tool labels Feb 19, 2021 — with ASP.NET Core Issue Ranking
@javiercn javiercn added feature-mvc-razor-views Features related to the Razor view engine for Razor pages and MVC views feature-templates and removed feature-mvc-razor-views Features related to the Razor view engine for Razor pages and MVC views labels Apr 18, 2021
@mkArtakMSFT mkArtakMSFT added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Oct 20, 2021
@mkArtakMSFT mkArtakMSFT removed their assignment Oct 20, 2021
@captainsafia captainsafia added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates and removed old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-very-few This issue impacts very few customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-templates severity-nice-to-have This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

6 participants