Skip to content

Update API template to use new Problem helpers in error handler #8539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DamianEdwards opened this issue Mar 14, 2019 · 6 comments
Closed

Update API template to use new Problem helpers in error handler #8539

DamianEdwards opened this issue Mar 14, 2019 · 6 comments
Assignees
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one
Milestone

Comments

@DamianEdwards
Copy link
Member

Relies on #8537

Update error handler action method to use new problem helper method #8537:

[Route("/error")]
public ActionResult<ProblemDetails> HandleError()
{
    return new ProblemDetails
   {
        Title = "An error occurred while processing your request.",
        Status = 500
    };
}
@DamianEdwards DamianEdwards added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 14, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview6 milestone Mar 20, 2019
@mkArtakMSFT mkArtakMSFT added 1 - Ready enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Mar 20, 2019
@isaacrlevin
Copy link
Contributor

@mkArtakMSFT this good to take now after latest PR?

@mkArtakMSFT
Copy link
Contributor

I'm not sure I understand you question, @isaac2004.
Are you asking whether you can take this and send a PR for it? If so - that'll be amazing. We'll happily review a PR for this.

@ryanbrandenburg
Copy link
Contributor

#8537 is still open. Has it actually been completed and we just missed updating it? Or does this issue not actually rely on that one somehow?

@mkArtakMSFT
Copy link
Contributor

@ryanbrandenburg you're right. The referenced issues would make this much easier to accomplish. So that should come first.

@mkArtakMSFT mkArtakMSFT added the blocked The work on this issue is blocked due to some dependency label Jul 18, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview9, 3.1.0 Jul 31, 2019
@pranavkm pranavkm removed the blocked The work on this issue is blocked due to some dependency label Aug 5, 2019
@pranavkm
Copy link
Contributor

pranavkm commented Aug 5, 2019

Unblocked now

@mkArtakMSFT mkArtakMSFT removed this from the 3.0.0-preview9 milestone Aug 14, 2019
@mkArtakMSFT mkArtakMSFT added this to the 5.0.0 milestone Aug 14, 2019
@mkArtakMSFT
Copy link
Contributor

Moving to 5.0 after discussing this with @glennc and @pranavkm

@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests

5 participants