Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure targeting pack dependency versions are pinned for patch builds. #8633

Closed
JunTaoLuo opened this issue Mar 18, 2019 · 11 comments
Closed
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone

Comments

@JunTaoLuo
Copy link
Contributor

#8490 (comment)

@JunTaoLuo JunTaoLuo added bug This issue describes a behavior which is not expected - a bug. feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform labels Mar 18, 2019
@Eilon Eilon added this to the 3.0.0 milestone Apr 5, 2019
@Eilon
Copy link
Member

Eilon commented Apr 5, 2019

Needs to be done at ~RTM time, before we ship any patch. Might need to be done earlier if we do a patch prototype prior to RTM, which is a likely possibility.

@natemcmaster
Copy link
Contributor

@Pilchie this one affects servicing 3.0.x and would be good to review for RTM.

@analogrelay
Copy link
Contributor

If I'm understanding correctly, the main work here is to ensure the deb and rpm packages have a fixed dependency to 3.0.0 of the .NET Core targeting pack, right? Seems straightforward enough. We can't actually make that change until we ship though, since we do need to reference the active preview version as we're still shipping previews.

@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0, 3.0.2, 3.0.1 Oct 17, 2019
@dougbu
Copy link
Member

dougbu commented Nov 5, 2019

At this point, our incoming ref packages (from Extensions and core-setup) should both be pinned at 3.0.0. The remaining work before we close this issue is to stop building the AspNetCore targeting pack after 3.0.1 ships.

@JunTaoLuo please confirm

@JunTaoLuo
Copy link
Contributor Author

That is correct, we have pinned the ref pack version in the deb and rpm installers. However, there shouldn't be any work required to stop building the targeting pack since it's already conditional on 3.0.1: https://github.com/aspnet/AspNetCore/blob/release/3.0/Directory.Build.props#L93-L94.

@JunTaoLuo
Copy link
Contributor Author

Curious if any of this logic will be impacted by the 3.0.2 changes you're making @dougbu ?

@dougbu
Copy link
Member

dougbu commented Nov 5, 2019

Not really. I am however concerned about what will happen w/ the checked-in approach once we stop building the targeting pack. Will the infrastructure still build ref/ projects and reference them? Can we test today or tomorrow to make sure we're 🆗?

@JunTaoLuo
Copy link
Contributor Author

I'll try it out and report back.

@JunTaoLuo JunTaoLuo modified the milestones: 3.0.1, 3.0.2 Nov 11, 2019
@wtgodbe
Copy link
Member

wtgodbe commented Nov 25, 2019

@JunTaoLuo are you on this for 3.1.1 as well?

@JunTaoLuo
Copy link
Contributor Author

I think there's no longer any action to take here. We have updated the targeting pack dependencies to use the version of Microsoft.NETCore.App.Ref dependency: https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Installers/Debian/TargetingPack/debian_config.json.in#L33. The same is also true for 3.1 and master. Given that in 3.0 we have pinned the dependency at 3.0.0 (and 3.1.0 in 3.1) the dependency version will be correct if we ever need to service the targeting pack again.

@dougbu
Copy link
Member

dougbu commented Dec 11, 2019

Fine to close since we also confirmed the Microsoft.Internal.Extensions.Ref versions coming into AspNetCore are pinned.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 12, 2020
@dougbu dougbu added the Done This issue has been fixed label May 5, 2020
@JunTaoLuo JunTaoLuo added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform labels Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Development

No branches or pull requests

7 participants