-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure targeting pack dependency versions are pinned for patch builds. #8633
Comments
Needs to be done at ~RTM time, before we ship any patch. Might need to be done earlier if we do a patch prototype prior to RTM, which is a likely possibility. |
@Pilchie this one affects servicing 3.0.x and would be good to review for RTM. |
If I'm understanding correctly, the main work here is to ensure the |
At this point, our incoming ref packages (from Extensions and core-setup) should both be pinned at 3.0.0. The remaining work before we close this issue is to stop building the AspNetCore targeting pack after 3.0.1 ships. @JunTaoLuo please confirm |
That is correct, we have pinned the ref pack version in the deb and rpm installers. However, there shouldn't be any work required to stop building the targeting pack since it's already conditional on 3.0.1: https://github.com/aspnet/AspNetCore/blob/release/3.0/Directory.Build.props#L93-L94. |
Curious if any of this logic will be impacted by the 3.0.2 changes you're making @dougbu ? |
Not really. I am however concerned about what will happen w/ the checked-in approach once we stop building the targeting pack. Will the infrastructure still build ref/ projects and reference them? Can we test today or tomorrow to make sure we're 🆗? |
I'll try it out and report back. |
@JunTaoLuo are you on this for 3.1.1 as well? |
I think there's no longer any action to take here. We have updated the targeting pack dependencies to use the version of Microsoft.NETCore.App.Ref dependency: https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Installers/Debian/TargetingPack/debian_config.json.in#L33. The same is also true for 3.1 and master. Given that in 3.0 we have pinned the dependency at 3.0.0 (and 3.1.0 in 3.1) the dependency version will be correct if we ever need to service the targeting pack again. |
Fine to close since we also confirmed the Microsoft.Internal.Extensions.Ref versions coming into AspNetCore are pinned. |
#8490 (comment)
The text was updated successfully, but these errors were encountered: