-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sample build on push to samples repo #243
Comments
@hakenr ... Made it here for work on building samples. I'd prefer ...... I think 🤔 ...... to set up the builds on a per-sample push basis and not restore and rebuild all of them for any given push to one sample. I'm new to many Action concepts. It seems like it would require one Action YAML file per sample. Like this ... ... because it looks like the push path must be set in Also curious why you had separate restore and build steps in your script? Why not just build, given that it restores first? WRT which SDK to grab, I thought that the latest could build all prior versions. Did you set up your script with the SDK matching the app's release version to avoid any kind of EOL scenario for a prior release? |
Yeah ... I think conditionals ( |
Not sure. It was most likely taken from a GitHub Action template (or created by some GitHub wizard). GPT-4o says it's a recommended approach and provides a few reasons - mainly related to maintainability, discoverability, and those "software craftsmanship" aspects. |
Right ... I see. I think just a straight build would be fine. AI ... not my favorite source of information. 😆 I'm looking now on how one might control the steps of a job based on a path conditional. I haven't found it yet, but I really have a hard time with the GH docs. This is about the third time that I went looking for some seemingly simple use case information and couldn't find it. I know a guy who should be able to help if I can't track down the information that I'm seeking. |
I think the "latest SDK" approach could work well. It's "good enough" to catch serious build-time errors and "simple enough" to maintain. However, there's a chance that the latest SDK might compile newer constructs that weren't available in older versions or include fixes that could make the build behave differently compared to the original version. |
Very well. AFAIK, it should be ok. When this is set up and tested, I think we'll see fairly fast if things are going to 💥 using the 9.0 SDK to build the 3.1 samples here. WRT controlling the job steps paths, I'll wire up https://github.com/dorny/paths-filter. I should then be able to control individual sample builds by push paths. I'll work on implementing that approach now to see if it will work. |
Yes, this approach will work well to only build the sample(s) pushed ... Next, I'll add in the paths for the other samples. |
We'll need to get approval for this and have the docs management set it up. Enabling it myself ended up generating an internal policy violation.#242Resolved! 🎉
The text was updated successfully, but these errors were encountered: