Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK resolver should flow traced errors from hostfxr to msbuild #10354

Open
nguerrera opened this issue Jun 28, 2019 · 2 comments
Open

SDK resolver should flow traced errors from hostfxr to msbuild #10354

nguerrera opened this issue Jun 28, 2019 · 2 comments

Comments

@nguerrera
Copy link
Contributor

Follow up to https://github.com/dotnet/core-setup/issues/6970

As of now, the that is shown in VS when sdk resolution fails is overly generic:

https://github.com/dotnet/cli/blob/6b0885139c1f37093ba4d3797f46fe90bf093883/src/Microsoft.DotNet.MSBuildSdkResolver/Strings.resx#L133

We can set an error writer on hostfxr and then return the more specific errors to msbuild, and ultimately VS.

See https://github.com/dotnet/core-setup/blob/1a10af88e3904b1d9790be38450c23eea683d6ae/src/corehost/cli/fxr/hostfxr.cpp#L391

cc @peterhuene

@nguerrera
Copy link
Contributor Author

cc @KathleenDollard

@nguerrera
Copy link
Contributor Author

It would be nice to be able to plumb warnings too, and to have a flag that can be set somehow to get all the informational tracing as well into the binlog, but that is blocked by https://github.com/dotnet/core-setup/issues/6972

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 3.0.1xx milestone Jan 31, 2020
@marcpopMSFT marcpopMSFT modified the milestones: 3.0.1xx, Backlog Oct 26, 2021
@dsplaisted dsplaisted modified the milestones: Backlog, 7.0.1xx Oct 26, 2021
@marcpopMSFT marcpopMSFT modified the milestones: 7.0.1xx, Backlog Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants