Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No TypeScript files in VS2017 #7209

Closed
colltoaction opened this issue Nov 19, 2016 · 6 comments
Closed

No TypeScript files in VS2017 #7209

colltoaction opened this issue Nov 19, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@colltoaction
Copy link

[moved from https://github.com/Microsoft/msbuild/issues/1354]

Just downloaded VS2017 and migrated my project.json-based project. This was created using the Angular 2 template that can be found in https://github.com/aspnet/JavaScriptServices.

Now my TypeScript files are not shown and there are many .js and .map.js files created automatically.

What would be the correct configuration to have what I had before this?


After posting the original question I found these settings are enough for my scenario, but the migration experience still wasn't complete and that's a bug in my opinion:

<PropertyGroup>
  <TypeScriptCompileBlocked>true</TypeScriptCompileBlocked>
</PropertyGroup>

<ItemGroup>
  <None Include="ClientApp\**\*.scss" />
  <None Include="ClientApp\**\*.ts" />
</ItemGroup>

Thanks!

@TheRealPiotrP
Copy link
Contributor

@mlorbetske I'm not familiar with this aspnet template. Thoughts on how we could migrate more effectively?

@SteveSandersonMS
Copy link
Member

Seems like it should be possible to migrate:

  • Preserve the <TypeScriptCompileBlocked>true</TypeScriptCompileBlocked> value if it's is present in the .xproj that's being migrated
  • Ensure that all original files show up in solution explorer (.ts, .js, .json, .css, .less, .sass, .png, etc.), like they did with .xproj

@TheRealPiotrP
Copy link
Contributor

@SteveSandersonMS thus far migration has been limited to project.json. We'll need to look at opportunities to selectively migrate xproj content for these projects.

@livarcocc
Copy link
Contributor

@mlorbetske Is this something that the Web SDK is handling already?

@mlorbetske
Copy link
Contributor

The inclusion of the typescript files in the project is handled by the WebSDK. For the actual integration with the Typescript build, we're working with that team to complete the story.

@livarcocc
Copy link
Contributor

Ok, seems like migration will get it for free then. I am closing this issue. If there is something else we should do as part of migration for this, please, re-activate.

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants