Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameters to align on the word "completion" #1898

Closed
Tracked by #1891
jonsequitur opened this issue Nov 2, 2022 · 0 comments · Fixed by #1951
Closed
Tracked by #1891

Rename parameters to align on the word "completion" #1898

jonsequitur opened this issue Nov 2, 2022 · 0 comments · Fixed by #1951
Assignees
Labels
Area-API Area-Completions Related to support for tab completion
Milestone

Comments

@jonsequitur
Copy link
Contributor

jonsequitur commented Nov 2, 2022

        // Why is this one "values" and the other two are "complete"?
        // Since the method is called "AddCompletions" I'd expect things to be called a "completion".
        public static TArgument AddCompletions<TArgument>(this TArgument argument, string[] values);
        public static TArgument AddCompletions<TArgument>(this TArgument argument, Func<CompletionContext,IEnumerable<string>> complete);
        public static TArgument AddCompletions<TArgument>(this TArgument argument, CompletionDelegate complete);
@jonsequitur jonsequitur mentioned this issue Nov 2, 2022
56 tasks
@jonsequitur jonsequitur added Area-API Area-Completions Related to support for tab completion labels Nov 2, 2022
@jozkee jozkee self-assigned this Nov 4, 2022
@jonsequitur jonsequitur added this to the 2.0 GA milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-API Area-Completions Related to support for tab completion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants