Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 20b54ac

Browse files
committed
Remove useless variable
Remove compArgRegCount and compFlatArgRegCount in Info struct
1 parent 44eebc7 commit 20b54ac

File tree

4 files changed

+19
-24
lines changed

4 files changed

+19
-24
lines changed

src/jit/compiler.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8343,10 +8343,8 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
83438343
unsigned compArgsCount; // Number of arguments (incl. implicit and hidden)
83448344

83458345
#if FEATURE_FASTTAILCALL
8346-
unsigned compArgRegCount; // Number of incoming integer argument registers used for incoming arguments
8347-
unsigned compFloatArgRegCount; // Number of incoming floating argument registers used for incoming arguments
8348-
size_t compArgStackSize; // Incoming argument stack size in bytes
8349-
#endif // FEATURE_FASTTAILCALL
8346+
size_t compArgStackSize; // Incoming argument stack size in bytes
8347+
#endif // FEATURE_FASTTAILCALL
83508348

83518349
unsigned compRetBuffArg; // position of hidden return param var (0, 1) (BAD_VAR_NUM means not present);
83528350
int compTypeCtxtArg; // position of hidden param for type context for generic code (CORINFO_CALLCONV_PARAMTYPE)

src/jit/lclvars.cpp

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -235,17 +235,6 @@ void Compiler::lvaInitTypeRef()
235235

236236
lvaInitArgs(&varDscInfo);
237237

238-
#if FEATURE_FASTTAILCALL
239-
//-------------------------------------------------------------------------
240-
// Save the register usage information and stack size.
241-
//-------------------------------------------------------------------------
242-
243-
info.compArgRegCount = varDscInfo.intRegArgNum;
244-
info.compFloatArgRegCount = varDscInfo.floatRegArgNum;
245-
info.compArgStackSize = varDscInfo.stackArgSize;
246-
247-
#endif // FEATURE_FASTTAILCALL
248-
249238
//-------------------------------------------------------------------------
250239
// Finally the local variables
251240
//-------------------------------------------------------------------------
@@ -367,6 +356,13 @@ void Compiler::lvaInitArgs(InitVarDscInfo* varDscInfo)
367356
codeGen->floatRegState.rsCalleeRegArgCount = varDscInfo->floatRegArgNum;
368357
#endif // FEATURE_STACK_FP_X87
369358

359+
#if FEATURE_FASTTAILCALL
360+
// Save the stack usage information
361+
// We can get register usage information using codeGen->intRegState and
362+
// codeGen->floatRegState
363+
info.compArgStackSize = varDscInfo->stackArgSize;
364+
#endif // FEATURE_FASTTAILCALL
365+
370366
// The total argument size must be aligned.
371367
noway_assert((compArgSize % sizeof(void*)) == 0);
372368

@@ -951,7 +947,7 @@ void Compiler::lvaInitUserArgs(InitVarDscInfo* varDscInfo)
951947

952948
#endif // _TARGET_XXX_
953949

954-
#ifdef FEATURE_FASTTAILCALL
950+
#if FEATURE_FASTTAILCALL
955951
varDscInfo->stackArgSize += (unsigned)roundUp(argSize, TARGET_POINTER_SIZE);
956952
#endif // FEATURE_FASTTAILCALL
957953
}
@@ -1050,9 +1046,9 @@ void Compiler::lvaInitGenericsCtxt(InitVarDscInfo* varDscInfo)
10501046
// For the RyuJIT backend, we need to mark these as being on the stack,
10511047
// as this is not done elsewhere in the case that canEnreg returns false.
10521048
varDsc->lvOnFrame = true;
1053-
#ifdef FEATURE_FASTTAILCALL
1049+
#if FEATURE_FASTTAILCALL
10541050
varDscInfo->stackArgSize += TARGET_POINTER_SIZE;
1055-
#endif
1051+
#endif // FEATURE_FASTTAILCALL
10561052
}
10571053
#endif // !LEGACY_BACKEND
10581054

@@ -1126,9 +1122,9 @@ void Compiler::lvaInitVarArgsHandle(InitVarDscInfo* varDscInfo)
11261122
// For the RyuJIT backend, we need to mark these as being on the stack,
11271123
// as this is not done elsewhere in the case that canEnreg returns false.
11281124
varDsc->lvOnFrame = true;
1129-
#ifdef FEATURE_FASTTAILCALL
1125+
#if FEATURE_FASTTAILCALL
11301126
varDscInfo->stackArgSize += TARGET_POINTER_SIZE;
1131-
#endif
1127+
#endif // FEATURE_FASTTAILCALL
11321128
}
11331129
#endif // !LEGACY_BACKEND
11341130

src/jit/morph.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7253,8 +7253,8 @@ bool Compiler::fgCanFastTailCall(GenTreeCall* callee)
72537253
// Note that callee being a vararg method is not a problem since we can account the params being passed.
72547254
unsigned nCallerArgs = info.compArgsCount;
72557255

7256-
size_t callerArgRegCount = info.compArgRegCount;
7257-
size_t callerFloatArgRegCount = info.compFloatArgRegCount;
7256+
size_t callerArgRegCount = codeGen->intRegState.rsCalleeRegArgCount;
7257+
size_t callerFloatArgRegCount = codeGen->floatRegState.rsCalleeRegArgCount;
72587258

72597259
// Count the callee args including implicit and hidden.
72607260
// Note that GenericContext and VarargCookie are added by importer while

src/jit/register_arg_convention.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ struct InitVarDscInfo
2626
bool anyFloatStackArgs;
2727
#endif // _TARGET_ARM_
2828

29-
#ifdef FEATURE_FASTTAILCALL
29+
#if FEATURE_FASTTAILCALL
30+
// It is used to calculate argument stack size information in byte
3031
unsigned stackArgSize;
3132
#endif // FEATURE_FASTTAILCALL
3233

@@ -47,7 +48,7 @@ struct InitVarDscInfo
4748
anyFloatStackArgs = false;
4849
#endif // _TARGET_ARM_
4950

50-
#ifdef FEATURE_FASTTAILCALL
51+
#if FEATURE_FASTTAILCALL
5152
stackArgSize = 0;
5253
#endif // FEATURE_FASTTAILCALL
5354
}

0 commit comments

Comments
 (0)