Make member visibility first accross corlib

Mechanical find&replace to match https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md

Author: jkotas

src/mscorlib/shared/Interop/Unix/Interop.Errors.cs

@@ -186,7 +186,7 @@ internal static unsafe string StrError(int platformErrno)
         internal static extern int ConvertErrorPalToPlatform(Error error);
 
         [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_StrErrorR")]
-        private static unsafe extern byte* StrErrorR(int platformErrno, byte* buffer, int bufferSize);
+        private static extern unsafe byte* StrErrorR(int platformErrno, byte* buffer, int bufferSize);
     }
 }
 

src/mscorlib/shared/Interop/Unix/System.Globalization.Native/Interop.Idna.cs

@@ -13,9 +13,9 @@ internal static partial class Globalization
         internal const int UseStd3AsciiRules = 0x2;
 
         [DllImport(Libraries.GlobalizationNative, CharSet = CharSet.Unicode, EntryPoint = "GlobalizationNative_ToAscii")]
-        internal static unsafe extern int ToAscii(uint flags, char* src, int srcLen, char* dstBuffer, int dstBufferCapacity);
+        internal static extern unsafe int ToAscii(uint flags, char* src, int srcLen, char* dstBuffer, int dstBufferCapacity);
 
         [DllImport(Libraries.GlobalizationNative, CharSet = CharSet.Unicode, EntryPoint = "GlobalizationNative_ToUnicode")]
-        internal static unsafe extern int ToUnicode(uint flags, char* src, int srcLen, char* dstBuffer, int dstBufferCapacity);
+        internal static extern unsafe int ToUnicode(uint flags, char* src, int srcLen, char* dstBuffer, int dstBufferCapacity);
     }
 }

src/mscorlib/shared/Interop/Unix/System.Native/Interop.GetRandomBytes.cs

@@ -11,7 +11,7 @@ internal partial class Interop
     internal unsafe partial class Sys
     {
         [DllImport(Interop.Libraries.SystemNative, EntryPoint = "SystemNative_GetNonCryptographicallySecureRandomBytes")]
-        internal static unsafe extern void GetNonCryptographicallySecureRandomBytes(byte* buffer, int length);
+        internal static extern unsafe void GetNonCryptographicallySecureRandomBytes(byte* buffer, int length);
     }
 
     internal static unsafe void GetRandomBytes(byte* buffer, int length)

src/mscorlib/shared/Interop/Unix/System.Native/Interop.Read.cs

@@ -20,6 +20,6 @@ internal static partial class Sys
         /// Note - on fail. the position of the stream may change depending on the platform; consult man 2 read for more info
         /// </returns>
         [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_Read", SetLastError = true)]
-        internal static unsafe extern int Read(SafeFileHandle fd, byte* buffer, int count);
+        internal static extern unsafe int Read(SafeFileHandle fd, byte* buffer, int count);
     }
 }

src/mscorlib/shared/Interop/Unix/System.Native/Interop.Write.cs

@@ -19,9 +19,9 @@ internal static partial class Sys
         /// Returns the number of bytes written on success; otherwise, returns -1 and sets errno
         /// </returns>
         [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_Write", SetLastError = true)]
-        internal static unsafe extern int Write(SafeFileHandle fd, byte* buffer, int bufferSize);
+        internal static extern unsafe int Write(SafeFileHandle fd, byte* buffer, int bufferSize);
 
         [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_Write", SetLastError = true)]
-        internal static unsafe extern int Write(int fd, byte* buffer, int bufferSize);
+        internal static extern unsafe int Write(int fd, byte* buffer, int bufferSize);
     }
 }

src/mscorlib/shared/Interop/Windows/BCrypt/Interop.BCryptGenRandom.cs

@@ -23,7 +23,7 @@ internal static unsafe int BCryptGenRandom(byte* pbBuffer, int count)
         internal const int STATUS_NO_MEMORY = unchecked((int)0xC0000017);
 
         [DllImport(Libraries.BCrypt, CharSet = CharSet.Unicode)]
-        private static unsafe extern int BCryptGenRandom(IntPtr hAlgorithm, byte* pbBuffer, int cbBuffer, int dwFlags);
+        private static extern unsafe int BCryptGenRandom(IntPtr hAlgorithm, byte* pbBuffer, int cbBuffer, int dwFlags);
     }
 
     internal static unsafe void GetRandomBytes(byte* buffer, int length)

src/mscorlib/shared/System/Diagnostics/Tracing/EventProvider.cs

@@ -1133,7 +1133,7 @@ internal unsafe bool WriteEvent(ref EventDescriptor eventDescriptor, IntPtr even
         // <CallsSuppressUnmanagedCode Name="UnsafeNativeMethods.ManifestEtw.EventWrite(System.Int64,EventDescriptor&,System.UInt32,System.Void*):System.UInt32" />
         // </SecurityKernel>
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1045:DoNotPassTypesByReference")]
-        internal unsafe protected bool WriteEvent(ref EventDescriptor eventDescriptor, IntPtr eventHandle, Guid* activityID, Guid* childActivityID, int dataCount, IntPtr data)
+        internal protected unsafe bool WriteEvent(ref EventDescriptor eventDescriptor, IntPtr eventHandle, Guid* activityID, Guid* childActivityID, int dataCount, IntPtr data)
         {
             if (childActivityID != null)
             {

src/mscorlib/shared/System/Diagnostics/Tracing/EventSource.cs

@@ -1955,7 +1955,7 @@ private unsafe void WriteEventVarargs(int eventId, Guid* childActivityID, object
             }
         }
 
-        unsafe private object[] SerializeEventArgs(int eventId, object[] args)
+        private unsafe object[] SerializeEventArgs(int eventId, object[] args)
         {
             TraceLoggingEventTypes eventTypes = m_eventData[eventId].TraceLoggingEventTypes;
             if (eventTypes == null)
@@ -2012,7 +2012,7 @@ private void LogEventArgsMismatches(ParameterInfo[] infos, object[] args)
 #endif //!ES_BUILD_PCL
         }
 
-        unsafe private void WriteToAllListeners(int eventId, Guid* childActivityID, int eventDataCount, EventSource.EventData* data)
+        private unsafe void WriteToAllListeners(int eventId, Guid* childActivityID, int eventDataCount, EventSource.EventData* data)
         {
             // We represent a byte[] as a integer denoting the length  and then a blob of bytes in the data pointer. This causes a spurious
             // warning because eventDataCount is off by one for the byte[] case since a byte[] has 2 items associated it. So we want to check
@@ -2047,7 +2047,7 @@ unsafe private void WriteToAllListeners(int eventId, Guid* childActivityID, int
         }
 
         // helper for writing to all EventListeners attached the current eventSource.  
-        unsafe private void WriteToAllListeners(int eventId, Guid* childActivityID, params object[] args)
+        private unsafe void WriteToAllListeners(int eventId, Guid* childActivityID, params object[] args)
         {
             EventWrittenEventArgs eventCallbackArgs = new EventWrittenEventArgs(this);
             eventCallbackArgs.EventId = eventId;

src/mscorlib/shared/System/Guid.cs

@@ -1232,7 +1232,7 @@ private static char HexToChar(int a)
             return (char)((a > 9) ? a - 10 + 0x61 : a + 0x30);
         }
 
-        unsafe private static int HexsToChars(char* guidChars, int a, int b)
+        private unsafe static int HexsToChars(char* guidChars, int a, int b)
         {
             guidChars[0] = HexToChar(a >> 4);
             guidChars[1] = HexToChar(a);
@@ -1243,7 +1243,7 @@ unsafe private static int HexsToChars(char* guidChars, int a, int b)
             return 4;
         }
 
-        unsafe private static int HexsToCharsHexOutput(char* guidChars, int a, int b)
+        private unsafe static int HexsToCharsHexOutput(char* guidChars, int a, int b)
         {
             guidChars[0] = '0';
             guidChars[1] = 'x';

src/mscorlib/shared/System/IO/FileStream.Windows.cs

@@ -850,7 +850,7 @@ private Task<int> ReadAsyncInternal(Memory<byte> destination, CancellationToken
             }
         }
 
-        unsafe private Task<int> ReadNativeAsync(Memory<byte> destination, int numBufferedBytesRead, CancellationToken cancellationToken)
+        private unsafe Task<int> ReadNativeAsync(Memory<byte> destination, int numBufferedBytesRead, CancellationToken cancellationToken)
         {
             AssertCanRead();
             Debug.Assert(_useAsyncIO, "ReadNativeAsync doesn't work on synchronous file streams!");

src/mscorlib/shared/System/IO/PathInternal.cs

@@ -63,7 +63,7 @@ internal static int GetCommonPathLength(string first, string second, bool ignore
         /// <summary>
         /// Gets the count of common characters from the left optionally ignoring case
         /// </summary>
-        unsafe internal static int EqualStartingCharacterCount(string first, string second, bool ignoreCase)
+        internal unsafe static int EqualStartingCharacterCount(string first, string second, bool ignoreCase)
         {
             if (string.IsNullOrEmpty(first) || string.IsNullOrEmpty(second)) return 0;
 

src/mscorlib/shared/System/IntPtr.cs

@@ -23,7 +23,7 @@ public struct IntPtr : IEquatable<IntPtr>, ISerializable
         // See https://github.com/dotnet/corert/blob/master/Documentation/design-docs/diagnostics/diagnostics-tools-contract.md for more details. 
         // Please do not change the type, the name, or the semantic usage of this member without understanding the implication for tools. 
         // Get in touch with the diagnostics team if you have questions.
-        unsafe private void* _value; // Do not rename (binary serialization)
+        private unsafe void* _value; // Do not rename (binary serialization)
 
         [Intrinsic]
         public static readonly IntPtr Zero;

src/mscorlib/shared/System/Text/StringBuilder.cs

@@ -2044,7 +2044,7 @@ private bool StartsWith(StringBuilder chunk, int indexInChunk, int count, string
         /// </param>
         /// <param name="value">The pointer to the start of the character buffer.</param>
         /// <param name="count">The number of characters in the buffer.</param>
-        unsafe private void ReplaceInPlaceAtChunk(ref StringBuilder chunk, ref int indexInChunk, char* value, int count)
+        private unsafe void ReplaceInPlaceAtChunk(ref StringBuilder chunk, ref int indexInChunk, char* value, int count)
         {
             if (count != 0)
             {

src/mscorlib/shared/System/Text/UTF8Encoding.cs

@@ -783,13 +783,13 @@ internal override unsafe int GetByteCount(char* chars, int count, EncoderNLS bas
         // diffs two char pointers using unsigned arithmetic. The unsigned arithmetic
         // is good enough for us, and it tends to generate better code than the signed
         // arithmetic generated by default
-        unsafe private static int PtrDiff(char* a, char* b)
+        private unsafe static int PtrDiff(char* a, char* b)
         {
             return (int)(((uint)((byte*)a - (byte*)b)) >> 1);
         }
 
         // byte* flavor just for parity
-        unsafe private static int PtrDiff(byte* a, byte* b)
+        private unsafe static int PtrDiff(byte* a, byte* b)
         {
             return (int)(a - b);
         }

src/mscorlib/shared/System/UIntPtr.cs

@@ -20,7 +20,7 @@ namespace System
     [System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
     public struct UIntPtr : IEquatable<UIntPtr>, ISerializable
     {
-        unsafe private void* _value; // Do not rename (binary serialization)
+        private unsafe void* _value; // Do not rename (binary serialization)
 
         [Intrinsic]
         public static readonly UIntPtr Zero;

src/mscorlib/src/Microsoft/Win32/UnsafeNativeMethods.cs

@@ -77,7 +77,7 @@ [In] string msg
                     );
 
             [StructLayout(LayoutKind.Sequential)]
-            unsafe internal struct EVENT_FILTER_DESCRIPTOR
+            internal unsafe struct EVENT_FILTER_DESCRIPTOR
             {
                 public long Ptr;
                 public int Size;

src/mscorlib/src/Microsoft/Win32/Win32Native.cs

@@ -22,7 +22,7 @@
  *  private static extern SafeFileHandle CreateFile(...);
  *
  *  [DllImport(Interop.Libraries.Kernel32, SetLastError=true)]
- *  unsafe internal static extern int ReadFile(SafeFileHandle handle, ...);
+ *  internal unsafe static extern int ReadFile(SafeFileHandle handle, ...);
  *
  *  [DllImport(Interop.Libraries.Kernel32, SetLastError=true)]
  *  internal static extern bool CloseHandle(IntPtr handle);
@@ -264,16 +264,16 @@ internal static bool GlobalMemoryStatusEx(ref MEMORYSTATUSEX buffer)
         private static extern bool GlobalMemoryStatusExNative([In, Out] ref MEMORYSTATUSEX buffer);
 
         [DllImport(Interop.Libraries.Kernel32, SetLastError = true)]
-        unsafe internal static extern UIntPtr VirtualQuery(void* address, ref MEMORY_BASIC_INFORMATION buffer, UIntPtr sizeOfBuffer);
+        internal unsafe static extern UIntPtr VirtualQuery(void* address, ref MEMORY_BASIC_INFORMATION buffer, UIntPtr sizeOfBuffer);
 
         // VirtualAlloc should generally be avoided, but is needed in 
         // the MemoryFailPoint implementation (within a CER) to increase the 
         // size of the page file, ignoring any host memory allocators.
         [DllImport(Interop.Libraries.Kernel32, SetLastError = true)]
-        unsafe internal static extern void* VirtualAlloc(void* address, UIntPtr numBytes, int commitOrReserve, int pageProtectionMode);
+        internal unsafe static extern void* VirtualAlloc(void* address, UIntPtr numBytes, int commitOrReserve, int pageProtectionMode);
 
         [DllImport(Interop.Libraries.Kernel32, SetLastError = true)]
-        unsafe internal static extern bool VirtualFree(void* address, UIntPtr numBytes, int pageFreeMode);
+        internal unsafe static extern bool VirtualFree(void* address, UIntPtr numBytes, int pageFreeMode);
 
         [DllImport(Interop.Libraries.Kernel32, CharSet = CharSet.Ansi, ExactSpelling = true, EntryPoint = "lstrlenA")]
         internal static extern int lstrlenA(IntPtr ptr);
@@ -324,7 +324,7 @@ internal static bool GlobalMemoryStatusEx(ref MEMORYSTATUSEX buffer)
         internal static extern bool CloseHandle(IntPtr handle);
 
         [DllImport(Interop.Libraries.Kernel32, SetLastError = true)]
-        internal static unsafe extern int WriteFile(SafeFileHandle handle, byte* bytes, int numBytesToWrite, out int numBytesWritten, IntPtr mustBeZero);
+        internal static extern unsafe int WriteFile(SafeFileHandle handle, byte* bytes, int numBytesToWrite, out int numBytesWritten, IntPtr mustBeZero);
 
         [DllImport(Interop.Libraries.Kernel32, SetLastError = true, CharSet = CharSet.Auto, BestFitMapping = false)]
         internal static extern SafeWaitHandle CreateSemaphoreEx(SECURITY_ATTRIBUTES lpSecurityAttributes, int initialCount, int maximumCount, string name, uint flags, uint desiredAccess);
@@ -371,10 +371,10 @@ internal static unsafe int GetEnvironmentVariable(string lpName, Span<char> lpVa
         }
 
         [DllImport(Interop.Libraries.Kernel32, CharSet = CharSet.Unicode)]
-        internal static unsafe extern char* GetEnvironmentStrings();
+        internal static extern unsafe char* GetEnvironmentStrings();
 
         [DllImport(Interop.Libraries.Kernel32, CharSet = CharSet.Unicode)]
-        internal static unsafe extern bool FreeEnvironmentStrings(char* pStrings);
+        internal static extern unsafe bool FreeEnvironmentStrings(char* pStrings);
 
         [DllImport(Interop.Libraries.Kernel32, CharSet = CharSet.Auto, SetLastError = true)]
         internal static extern uint GetCurrentProcessId();

src/mscorlib/src/System/ArgIterator.cs

@@ -39,7 +39,7 @@ public ArgIterator(RuntimeArgumentHandle arglist) : this(arglist.Value)
         }
 
         [MethodImplAttribute(MethodImplOptions.InternalCall)]
-        private unsafe extern ArgIterator(IntPtr arglist, void *ptr);
+        private extern unsafe ArgIterator(IntPtr arglist, void *ptr);
 
         // create an arg iterator that points just past 'firstArg'.  
         // 'arglist' is the value returned by the ARGLIST instruction
@@ -66,7 +66,7 @@ public TypedReference GetNextArg()
 
         [MethodImplAttribute(MethodImplOptions.InternalCall)]
         // reference to TypedReference is banned, so have to pass result as void pointer
-        private unsafe extern void FCallGetNextArg(void * result);
+        private extern unsafe void FCallGetNextArg(void * result);
 
         // Alternate version of GetNextArg() intended primarily for IJW code
         // generated by VC's "va_arg()" construct. 
@@ -102,7 +102,7 @@ public TypedReference GetNextArg(RuntimeTypeHandle rth)
 
         [MethodImplAttribute(MethodImplOptions.InternalCall)]
         // reference to TypedReference is banned, so have to pass result as void pointer
-        private unsafe extern void InternalGetNextArg(void * result, RuntimeType rt);
+        private extern unsafe void InternalGetNextArg(void * result, RuntimeType rt);
 
         // This method should invalidate the iterator (va_end). It is not supported yet.
         public void End()

src/mscorlib/src/System/Array.cs

@@ -476,12 +476,12 @@ public void SetValue(Object value, params long[] indices)
 
         [MethodImplAttribute(MethodImplOptions.InternalCall)]
         // reference to TypedReference is banned, so have to pass result as pointer
-        private unsafe extern void InternalGetReference(void* elemRef, int rank, int* pIndices);
+        private extern unsafe void InternalGetReference(void* elemRef, int rank, int* pIndices);
 
         // Ideally, we would like to use TypedReference.SetValue instead. Unfortunately, TypedReference.SetValue
         // always throws not-supported exception
         [MethodImplAttribute(MethodImplOptions.InternalCall)]
-        private unsafe extern static void InternalSetValue(void* target, Object value);
+        private extern unsafe static void InternalSetValue(void* target, Object value);
 
         public extern int Length
         {

src/mscorlib/src/System/Globalization/CompareInfo.Unix.cs

@@ -814,7 +814,7 @@ internal unsafe int GetHashCodeOfStringCore(string source, CompareOptions option
         }
 
         [DllImport(JitHelpers.QCall)]
-        private static unsafe extern int InternalHashSortKey(byte* sortKey, int sortKeyLength);
+        private static extern unsafe int InternalHashSortKey(byte* sortKey, int sortKeyLength);
 
         private static CompareOptions GetOrdinalCompareOptions(CompareOptions options)
         {

src/mscorlib/src/System/Globalization/EncodingDataItem.cs

@@ -26,14 +26,14 @@ internal class CodePageDataItem
         internal String m_bodyName;
         internal uint m_flags;
 
-        unsafe internal CodePageDataItem(int dataIndex)
+        internal unsafe CodePageDataItem(int dataIndex)
         {
             m_dataIndex = dataIndex;
             m_uiFamilyCodePage = EncodingTable.codePageDataPtr[dataIndex].uiFamilyCodePage;
             m_flags = EncodingTable.codePageDataPtr[dataIndex].flags;
         }
 
-        unsafe internal static String CreateString(sbyte* pStrings, uint index)
+        internal unsafe static String CreateString(sbyte* pStrings, uint index)
         {
             if (pStrings[0] == '|') // |str1|str2|str3
             {
@@ -68,7 +68,7 @@ unsafe internal static String CreateString(sbyte* pStrings, uint index)
             }
         }
 
-        unsafe public String WebName
+        public unsafe String WebName
         {
             get
             {
@@ -88,7 +88,7 @@ public virtual int UIFamilyCodePage
             }
         }
 
-        unsafe public String HeaderName
+        public unsafe String HeaderName
         {
             get
             {
@@ -100,7 +100,7 @@ unsafe public String HeaderName
             }
         }
 
-        unsafe public String BodyName
+        public unsafe String BodyName
         {
             get
             {
@@ -112,7 +112,7 @@ unsafe public String BodyName
             }
         }
 
-        unsafe public uint Flags
+        public unsafe uint Flags
         {
             get
             {

src/mscorlib/src/System/Globalization/EncodingTable.cs

@@ -33,12 +33,12 @@ internal static class EncodingTable
         //
         // This points to a native data table which maps an encoding name to the correct code page.        
         //
-        unsafe internal static InternalEncodingDataItem* encodingDataPtr = GetEncodingData();
+        internal unsafe static InternalEncodingDataItem* encodingDataPtr = GetEncodingData();
         //
         // This points to a native data table which stores the properties for the code page, and
         // the table is indexed by code page.
         //
-        unsafe internal static InternalCodePageDataItem* codePageDataPtr = GetCodePageData();
+        internal unsafe static InternalCodePageDataItem* codePageDataPtr = GetCodePageData();
         //
         // This caches the mapping of an encoding name to a code page.
         //
@@ -50,7 +50,7 @@ internal static class EncodingTable
 
         // Find the data item by binary searching the table that we have in native.
         // nativeCompareOrdinalWC is an internal-only function.
-        unsafe private static int internalGetCodePageFromName(String name)
+        private unsafe static int internalGetCodePageFromName(String name)
         {
             int left = 0;
             int right = lastEncodingItem;
@@ -161,7 +161,7 @@ internal static int GetCodePageFromName(String name)
             return codePage;
         }
 
-        unsafe internal static CodePageDataItem GetCodePageDataItem(int codepage)
+        internal unsafe static CodePageDataItem GetCodePageDataItem(int codepage)
         {
             CodePageDataItem dataItem;