Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RyuJIT] Enable CORINFO_INTRINSIC Round, Ceiling, and Floor to generate ROUNDSS and ROUNDSD #8993

Closed
tannergooding opened this issue Sep 22, 2017 · 3 comments · Fixed by dotnet/coreclr#14736
Closed

[RyuJIT] Enable CORINFO_INTRINSIC Round, Ceiling, and Floor to generate ROUNDSS and ROUNDSD #8993

tannergooding opened this issue Sep 22, 2017 · 3 comments · Fixed by dotnet/coreclr#14736
Labels
arch-x64 arch-x86 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions optimization tenet-performance Performance related issue
Milestone
Future

Comments

@tannergooding
Copy link
Member

SSE4.1 added the ROUNDSS and ROUNDSD instructions. For machines which support them, we should support emitting them for the Round, Ceiling, and Floor methods in System.Math and System.MathF.
@tannergooding tannergooding changed the title [RyuJIT] Enable CORINFO_INTRINSIC_Round to generate ROUNDSS and ROUNDSD [RyuJIT] Enable CORINFO_INTRINSIC Round, Ceiling, and Floor to generate ROUNDSS and ROUNDSD Sep 22, 2017
@tannergooding
Copy link
Member Author

FYI. @fiigii

I think this will be more readily possible once dotnet/coreclr#14020 goes in (since we will be able to properly distinguish SSE4.1 from SSE3; today they are combined into the InstructionSet_SSE3_4 value)

@fiigii
Copy link
Contributor

fiigii commented Sep 24, 2017

I think this will be more readily possible once dotnet/coreclr#14020 goes in (since we will be able to properly distinguish SSE4.1 from SSE3; today they are combined into the InstructionSet_SSE3_4 value)

Yes, I think so, and it will be finished soon. Are you implementing these math intrinsics?

@tannergooding
Copy link
Member Author

I plan on doing so, if someone else doesn't get to them first.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-x64 arch-x86 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions optimization tenet-performance Performance related issue
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Enable CORINFO_INTRINSIC Round, Ceiling, and Floor to generate ROUNDSS and ROUNDSD
3 participants
@fiigii @msftgits @tannergooding