Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need new CI modes for Intel hardware intrinsics #9464

Closed
fiigii opened this issue Dec 22, 2017 · 1 comment · Fixed by dotnet/coreclr#15784
Closed

Need new CI modes for Intel hardware intrinsics #9464

fiigii opened this issue Dec 22, 2017 · 1 comment · Fixed by dotnet/coreclr#15784
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Comments

@fiigii
Copy link
Contributor

fiigii commented Dec 22, 2017

Due to dotnet/coreclr#15514, most of the Intel hardware intrinsics are disabled by default. So we need the new CI modes with Debug and Checked build.

['COMPlus_EnableIncompleteISAClass' : '1'],
['COMPlus_EnableIncompleteISAClass' : '1', 'COMPlus_EnableAVX' : '0'], // test non-VEX-encoding 
['COMPlus_EnableIncompleteISAClass' : '1', 'COMPlus_EnableAVX2' : '0'], // test AVX CPUs
['COMPlus_EnableIncompleteISAClass' : '1', 'COMPlus_EnableSSE' : '0' , 'COMPlus_EnableSSE2' : '0' , 'COMPlus_EnableSSE3' : '0' , 'COMPlus_EnableSSSE3' : '0' , 'COMPlus_EnableSSE41' : '0' , 'COMPlus_EnableSSE42' : '0' , 'COMPlus_EnableAVX' : '0' , 'COMPlus_EnableAVX2' : '0' , 'COMPlus_EnableAES' : '0' , 'COMPlus_EnableBMI1' : '0' , 'COMPlus_EnableBMI2' : '0' , 'COMPlus_EnableFMA' : '0' , 'COMPlus_EnableLZCNT' : '0' , 'COMPlus_ EnablePCLMULQDQ' : '0' , 'COMPlus_EnablePOPCNT' : '0'],
['COMPlus_EnableIncompleteISAClass' : '1', 'COMPlus_FeatureSIMD' : '0'],

cc @BruceForstall @CarolEidt @jkotas @tannergooding

@4creators
Copy link
Contributor

4creators commented Dec 26, 2017

@fiigii @tannergooding
This can be done with support of CLRTestBatchPreCommands and BashCLRTestPreCommands MSBuild properties on a per directory or per test project basis. I have implemented it in my Sse2 tests in the following places:

https://github.com/dotnet/coreclr/pull/15585/files#diff-ed7fd7fe0842d20364c23fad645e6ffd where COMPlus_EnableIncompleteISAClass=1 is set for whole X86 directory and

https://github.com/dotnet/coreclr/pull/15585/files#diff-2ba0b8c1849292f8fa181ad58c8c164c where COMPlus_EnableAVX=0 is set to tests legacy Sse2 codegen

I will prepare PR to enable it independently of my dotnet/coreclr#15585 PR.

4creators referenced this issue in 4creators/coreclr Dec 26, 2017
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants