Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the 'emit immediate' logic in emitxarch #9559

Closed
tannergooding opened this issue Jan 16, 2018 · 1 comment
Closed

Simplify the 'emit immediate' logic in emitxarch #9559

tannergooding opened this issue Jan 16, 2018 · 1 comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Milestone
Future

Comments

@tannergooding
Copy link
Member

In emitxarch, we have a some duplicated logic for emitting immediate values to handle the imm8 and the imm16/imm32 case (ex: https://github.com/dotnet/coreclr/pull/14736/files/59db2cef21998c9680670a95939e77ee29ebc595#diff-a51165bc1fd2c0fa3987370e2e714356R8201).

It would be useful to create a helper method and contain this logic centrally where possible.

category:implementation
theme:emitter
skill-level:intermediate
cost:small
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@BruceForstall
Copy link
Member

Closing.

@BruceForstall BruceForstall removed the JitUntriaged CLR JIT issues needing additional triage label Oct 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@msftgits @tannergooding @BruceForstall