Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the indirect call fallback for HWIntrinsics executes the same instructions as the inlined version #10616

Closed
tannergooding opened this issue Jul 2, 2018 · 5 comments
Closed

Ensure that the indirect call fallback for HWIntrinsics executes the same instructions as the inlined version #10616

tannergooding opened this issue Jul 2, 2018 · 5 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Milestone
3.0

Comments

@tannergooding
Copy link
Member

There are a few Avx helper functions (namely Extract and Insert) which are emitting a managed software implementation rather than a switch table fallback.

These should be updated to use the switch table fallback instead.
@tannergooding
Copy link
Member Author

FYI. @CarolEidt, @fiigii, @eerhardt

This tracks the discussion here: dotnet/coreclr#18734 (comment)

@fiigii
Copy link
Contributor

fiigii commented Dec 6, 2018

Please close this issue.

@tannergooding
Copy link
Member Author

I think there are still a few APIs where we aren't validating this (namely the tests that aren't templated yet)....

Do we still have a bug tracking the move of all HWIntrinsic tests to be templated?

@fiigii
Copy link
Contributor

fiigii commented Dec 6, 2018

There are a few Avx helper functions (namely Extract and Insert)

We no longer have Avx.Extract/Insert helpers.

@tannergooding
Copy link
Member Author

tannergooding commented Dec 6, 2018 •
edited
Loading

Ah, I didn't read the top post, just the issue title.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@fiigii @msftgits @tannergooding