Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RyuJIT/arm64] Implement ELT hooks #10857

Closed
BruceForstall opened this issue Aug 8, 2018 · 7 comments · Fixed by dotnet/coreclr#26460
Closed

[RyuJIT/arm64] Implement ELT hooks #10857

BruceForstall opened this issue Aug 8, 2018 · 7 comments · Fixed by dotnet/coreclr#26460
Assignees
@echesakov
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Milestone
5.0.0

Comments

@BruceForstall
Copy link
Member

It looks like genProfilingEnterCallback and genProfilingLeaveCallback will NYI on arm64.
@AndyAyersMS
Copy link
Member

@BruceForstall seems like you should take this one?
cc @RussKeldorph

@BruceForstall BruceForstall self-assigned this Mar 12, 2019
@BruceForstall
Copy link
Member Author

I'll take it, but it's not a 3.0 issue, so I'll move it out of 3.0.

@AndyAyersMS
Copy link
Member

Can you comment on why it's not a 3.0 issue?

@BruceForstall
Copy link
Member Author

The diagnostics team does not include the profiling apis for arm64 as a 3.0 committed feature.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@k15tfu
Copy link
Contributor

k15tfu commented Mar 30, 2020

Hi! Can anyone update Milestone to 5.0?

@BruceForstall
Copy link
Member Author

Why do you want the milestone set to 5.0? It's already been fixed. Nonetheless, I'll do it.

@BruceForstall BruceForstall modified the milestones: Future, 5.0 Mar 30, 2020
@k15tfu
Copy link
Contributor

k15tfu commented Mar 30, 2020

5.0 the first version it will be fixed. Just want to specify it explicitly. Thanks

@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@echesakov echesakov

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Implement genProfilingEnterCallback genProfilingLeaveCallback on Arm64
5 participants
@k15tfu @echesakov @msftgits @AndyAyersMS @BruceForstall