Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$PYTHON in System.Private.Corlib.csproj is empty when opened via IDE #12675

Closed
EgorBo opened this issue May 9, 2019 · 1 comment
Closed

$PYTHON in System.Private.Corlib.csproj is empty when opened via IDE #12675

EgorBo opened this issue May 9, 2019 · 1 comment
Labels
area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner
Milestone
Future

Comments

@EgorBo
Copy link
Member

EgorBo commented May 9, 2019

See https://github.com/dotnet/coreclr/blob/master/src/System.Private.CoreLib/System.Private.CoreLib.csproj#L431
As far as I understand this variable is computed in build scripts where it's exported for the current process. However if I open the System.Private.CoreLib.sln in an IDE (VS/VSfM/Rider) I get

System.Private.CoreLib.csproj(418, 5): [MSB3073] The command """ 
/prj/coreclr-egor/src/System.Private.CoreLib/../scripts/check-definitions.py 
...... exited with code 127.

build.cmd saves PYTHON to %TEMP%\pythonlocation.txt so I guess System.Private.CoreLib.csproj could read it from there. (NOTE: build.sh doesn't save the computed path).
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 26, 2020
@jkotas
Copy link
Member

jkotas commented Apr 6, 2020

This was fixed a while ago.

@jkotas jkotas closed this as completed Apr 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@EgorBo @maryamariyan @jkotas @ericstj @msftgits