Remove version increment from Dictionary<K,V>.Remove overloads (#18854)

Wraith2 · stephentoub · commit 9edace057719 · 2018-07-14T18:12:26.000-04:00
* remove version increment from Remove overloads

* add temporary test exclusions

* fixup test exclusion names

* modify test exclusions

Signed-off-by: dotnet-bot &lt;dotnet-bot@microsoft.com&gt;
diff --git a/src/Common/src/CoreLib/System/Collections/Generic/Dictionary.cs b/src/Common/src/CoreLib/System/Collections/Generic/Dictionary.cs
@@ -796,7 +796,6 @@ public bool Remove(TKey key)
                         }
                         _freeList = i;
                         _freeCount++;
-                        _version++;
                         return true;
                     }
 
@@ -865,7 +864,6 @@ public bool Remove(TKey key, out TValue value)
                         }
                         _freeList = i;
                         _freeCount++;
-                        _version++;
                         return true;
                     }
 

Original file line number	Diff line number	Diff line change
`@@ -796,7 +796,6 @@ public bool Remove(TKey key)`
`796`	`796`	`}`
`797`	`797`	`_freeList = i;`
`798`	`798`	`_freeCount++;`
`799`		`- _version++;`
`800`	`799`	`return true;`
`801`	`800`	`}`
`802`	`801`
`@@ -865,7 +864,6 @@ public bool Remove(TKey key, out TValue value)`
`865`	`864`	`}`
`866`	`865`	`_freeList = i;`
`867`	`866`	`_freeCount++;`
`868`		`- _version++;`
`869`	`867`	`return true;`
`870`	`868`	`}`
`871`	`869`