Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLI version to support Ubuntu on Windows #18259

Closed
ericeil opened this issue Aug 22, 2016 · 6 comments
Closed

Update CLI version to support Ubuntu on Windows #18259

ericeil opened this issue Aug 22, 2016 · 6 comments
Assignees
@crummel @dagood
Milestone
2.0.0

Comments

@ericeil
Copy link
Contributor

ericeil commented Aug 22, 2016

Windows preview build 14905 now has enough kernel support to build/test CoreFx in the Ubuntu on Windows environment. However, the CLI build we are using still has the "execstack" issue, and so will not run on Ubuntu on Windows. This was fixed in the CoreCLR repo in April, and current public CLI builds seem to have the fix.

Can we update the CLI version in CoreFx to include the fix for https://github.com/dotnet/coreclr/issues/4048?
@ericeil
Copy link
Contributor Author

ericeil commented Aug 26, 2016

Just to be clear, I'm referring to the CLI that gets installed into the Tools directory.

@weshaggard
Copy link
Member

@crummel @dagood are going to be updating the CLI to what we shipped in .NET Core 1.0 RTM. Is the fix included in that version?

@ericeil
Copy link
Contributor Author

ericeil commented Aug 29, 2016

Is the fix included in that version?

Yes, I think it is.

@ericeil
Copy link
Contributor Author

ericeil commented Aug 31, 2016

Is there an ETA for getting this updated?

@dagood
Copy link
Member

dagood commented Sep 1, 2016

Getting buildtools on RTM shared framework is tracked by dotnet/buildtools#954. It's been preempted repeatedly but I got a RTM buildtools running (doing a build on Windows) yesterday afternoon. I'm aiming for a PR this morning although there might be delays in making sure it's compatible across repos/platforms.

@ericeil
Copy link
Contributor Author

ericeil commented Sep 8, 2016

dotnet/corefx#11387 seems to have enabled builds in Bash on Windows.

@ericeil ericeil closed this as completed Sep 8, 2016
ericeil referenced this issue in dotnet/corefx Sep 10, 2016
Work around known issues in "Ubuntu on Windows" (#11574)
d9aa92f 
The latest Windows 10 preview builds contain enough functionality in Ubuntu/Bash on Windows (a.k.a. Windows Subsystem for Linux, or WSL) that .NET Core mostly works now. With the fix for #11058, we can even build/test the CoreFx tree in this environment. Currently there are a few test failures; I've been working on identifying the causes of these, and filing bugs in the appropriate repos. 
This change implements workarounds for all of the current known issues in the "inner loop" tests. Mostly, I've just conditionally disabled tests when running in the WSL environment. 
There is still an issue, under investigation, causing non-deterministic failures in the System.Net.Http tests (microsoft/WSL#1068). And I haven't tried OuterLoop runs of anything but the networking tests.
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crummel crummel

@dagood dagood

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
5 participants
@ericeil @crummel @weshaggard @msftgits @dagood