-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Get/SetEnvironmentVariable to CoreLib #19463
Comments
@jkotas Any issues with doing this? cc: @ianhays, @stephentoub |
Sounds reasonable to me. |
The Windows-only overloads that write to registry may still stay in corefx. |
@JeremyKuhne we marked this for 1.2 -- let me know if you disagree. |
@JeremyKuhne does more remain here? I think you nentioned a change in the PAL. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Due to the lack of thread safety with environment variables on Unix the values are cached in the CoreFX implementation.
This causes
Path.GetTempPath()
and anything else that tries to get an environment variable in CoreLib to not have the up-to-date values. See the failing tests in dotnet/corefx#13920.We should move the implementation to Internal.Runtime.Augments so we have one source of truth.
The text was updated successfully, but these errors were encountered: