[netcoreapp2.0] 'AppDomain.CurrentDomain.GetAssemblies()' doesn't return the emitted dynamic assembly

[daxian-dbw]

AppDomain.CurrentDomain.GetAssemblies() doesn't return dynamically emitted assemblies.

Repro

using System;
using System.Reflection;
using System.Reflection.Emit;

namespace Sample
{
    class Program
    {
        static void Main(string[] args)
        {
            AssemblyName aName = new AssemblyName("Microsoft.PowerShell.Cmdletization.GeneratedTypes");
            AssemblyBuilder ab = AssemblyBuilder.DefineDynamicAssembly(aName, AssemblyBuilderAccess.Run);
            ModuleBuilder mb = ab.DefineDynamicModule(aName.Name);

            string fullEnumName = "Microsoft.PowerShell.Cmdletization.GeneratedTypes.TestEnum";
            Type underlyingType = typeof(Int32);
            EnumBuilder eb = mb.DefineEnum(fullEnumName, TypeAttributes.Public, underlyingType);

            eb.DefineLiteral("Single", 0);
            eb.DefineLiteral("Multiple", 1);

            TypeInfo ti = eb.CreateTypeInfo();

            Console.WriteLine("Dynamic assembly emitted: {0}", ti.Assembly.FullName);

            bool isEmittedAssemblyFound = false;
            var allAssemblies = AppDomain.CurrentDomain.GetAssemblies();
            foreach (Assembly item in allAssemblies)
            {
                if (item.FullName == ti.Assembly.FullName)
                {
                    isEmittedAssemblyFound = true;
                    Console.WriteLine("Found it");
                    break;
                }
            }

            if (!isEmittedAssemblyFound)
            {
                Console.WriteLine("AppDomain.CurrentDomain.GetAssemblies() doesn't return the emitted dynamic assemlby");
            }
        }
    }
}

Expected Result
The program prints Found it

Actual Result

Dynamic assembly emitted: Microsoft.PowerShell.Cmdletization.GeneratedTypes, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
AppDomain.CurrentDomain.GetAssemblies() doesn't return the emitted dynamic assemlby

Aren't dynamically emitted assembly loaded in the default assembly load context? Why AppDomain.CurrentDomain.GetAssemblies() not returning them?

[daxian-dbw]

@gkhanna79 is this a bug or another by-design behavior change?

[karelz]

@gkhanna79 who can answer it?

[gkhanna79]

Aren't dynamically emitted assembly loaded in the default assembly load context?

Dynamically emitted assemblies are loaded in the load context of the assembly that emitted them. Which LoadContext does your repro emit them in?

[daxian-dbw]

Which LoadContext does your repro emit them in?

It's in the default load context. You can see from the repro snippet, no additional load context is involved.

[gkhanna79]

@daxian-dbw Do you get the expected behavior on Desktop?

[daxian-dbw]

Yes, AppDomain.CurrentDomain.GetAssemblies returns the dynamic assembly as expected on Desktop.

F:\temp>test.exe
Dynamic assembly emitted: Microsoft.PowerShell.Cmdletization.GeneratedTypes, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
Found it

[gkhanna79]

PR with fix is out.