Add DirectoryServices tests

[karelz]

DirectoryServices has been ported without any test cases (see #14734). The tests require client-server setup (server running on Windows "Desktop" .NET Framework), which we do not support in our CI/test infrastructure.
Moreover the AD test server cannot run as public-internet-facing Azure server for the tests (it is not recommended by AD server team) :(

Idea: Create schema for adding tests, which will run only manually. Write the tests in such way that once we have client-server setup in CI/test infra, it will be easy to wrap them/migrate them into that structure.

Execution plan

1. Write a single typical-ish simplest DirectorySevices test.
   • The test will run against external AD test server (which can run locally or on another machine).
   • The test can be run only manually, not part of CI. Via special command line script.
   • Note: The test should also pass on full .NET Framework
2. Create client-server mini-infra for DirectoryServices tests.
   • Create simple unified way to propagate into the test information about the IP/port info of the external AD test server.
   • Enable running those tests manually, until we figure out how to enable client-server tests in CI/Helix test infra.
   • Note: The tests should be runnable also on full .NET Framework
   • Bonus: Make the mini-infra usable also for WCF tests which need Desktop-based WCF server (consider leveraging & partnering with existing WCF test suite - @zhenlan) and Networking tests which need sometimes client/server pieces of their test, currently depending on localhost (@karelz can ping the right experts on his Networking v-team)
3. Add more tests based on example from [1] and using DirectoryServices mini-infra [2]
   • This will allow us to run all DirectoryServices tests manually.

@tquerec @jay98014 can you please help us /guide us to create [1]. How to install AD test server locally / in a VM? Can you give us one Desktop test for DirectoryServices as example?
We should be able to make progress on [2] and [3] without your direct help.

[karelz]

@WinCPP was interested to help, esp. by end of July. [1] and [2] should be prep work earlier.

[WinCPP]

Thanks @karelz for looping me onto this. I am still going through #14734 , a lot of threads there... But as a start, I think I need to have an AD setup on my local machine to simulate the reconfigurable client-server setup? I enabled virtualization on my Win10 pro box, activated hyper-V. But then I realized I need to have a Windows installer... 😄 Am I on correct path...?

[hughbe]

I'm looking in to writing some unit style tests for System.DirectoryServices.Protocols (I don't think this should clash with your work).
I created the branch https://github.com/hughbe/corefx/tree/protocols-add-test-proj but when I run msbuild /T:BuildAndTest /P:Coverage=true, I get:

Committing...
No results, this could be for a number of reasons. The most common reasons are:

1. missing PDBs for the assemblies that match the filter please review the
   output file and refer to the Usage guide (Usage.rtf) about filters.
2. the profiler may not be registered correctly, please refer to the Usage
   guide and the -register switch.

Does anyone know why this happens?

[danmoseley]

@hughbe it's for reason 3. :) there is no coverage matching the -filter:"+[System.DirectoryServices.Protocols]*" (I see this when I opened the file C:\git\corefx\bin/Windows_NT.AnyCPU.Debug/System.DirectoryServices.Protocols.Tests/netstandard//RunTests.cmd)

I added var x= new System.DirectoryServices.Protocols.AddRequest(); and it says I have 0.3% coverage when I open up file:///C:/git/corefx/bin/tests/coverage/index.htm.

[hughbe]

I guess that makes sense - was thrown off by the missing PDBs stuff, thought it was a configuration issue. Cheers!

[tquerec]

There are a number of different options available for LDAP servers.

Active Directory - Available only as a windows server role
Active Directory Lightweight Directory Services - Available on Windows Server and as an optional feature on Windows client
3rd party LDAP stores - There are a number of open and closed source LDAP directories available. These include servers like SAMBA, Open LDAP, etc.

Each of the namespaces in S.DS.* has different directory server requirements.

S.DS -Requires any LDAP v3 compliant server.
S.DS.P - Requires any LDAP v3 compliant server.
S.DS.AM - Requires a Microsoft LDAP server, This could be Active Directory or AD LDS
S.DS.AD - Requires Active Directory

As long as we keep the configuration out of the code we should be able to write generic tests for S.DS and S.DS.P which work against any server type.

Starting with AD LDS or Open LDAP is probably the easiest route unless you already have a Windows Server license.

To install AD LDS on Windows 10 client

1. Open the Windows Features control panel
2. Check "Active Directory Lightweight Directory Services"
3. Select Ok
4. The AD LDS wizard will now be installed This MSDN link gives an overview on how to answer the wizard questions.

[hughbe]

@tquerec I'm trying to find "Active Directory Lightweight Directory Services" but can't seem to find anything in the panel

http://imgur.com/a/4xBse

[willdean]

@hughbe It's perhaps no help to you other than to save you wasting more time scrolling up and down, but this is what it looks like here: (Windows 10 Pro 10.0.14393)

Are you using Pro or Home?

[hughbe]

I don't get that unfortunately... I have home edition

[pasikarkkainen]

Hmm.. so what's the status here? Is anyone currently working on the DirectoryServices tests ?

[WinCPP]

@karelz I think I can start on this now. To start with I have created an instance of AD LDS on my Win 10 Pro machine at home as mentioned by @tquerec in one of the previous posts. From here, I think there are two things to be done predominantly - write tests using local instance and then wrap up whole thing using scripts to setup and tear down the instances (may be per build job run), including execution of the test cases. But I think for second to be done, basic tests need to be in place... Hope I'm thinking in right direction. The second part itself being an area of its own - automation infra as already discussed in this thread...

So if I were to do some quick stuff for part 1 i.e. creating test cases, can someone please point me to the API set that I can use to begin with. Or if I need to do something else, please let me know. I'll make them generic enough in terms of the server and instance to be used, as mentioned in this thread.

I think do I sound as if I've suddenly woken out of sleep 😄 ?

[karelz]

@tarekgh started working on it recently - he just forgot to assign it to himself ... @tarekgh can you use help from @WinCPP?

[karelz]

@tarekgh is it done? Can you please assign it to yourself and update appropriately? Thanks!

[tarekgh]

assigned it to me.