Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code under FEATURE_RANDOMIZED_STRING_HASHING from corefx #23311

Closed
jamesqo opened this issue Aug 24, 2017 · 2 comments
Closed

Remove code under FEATURE_RANDOMIZED_STRING_HASHING from corefx #23311

jamesqo opened this issue Aug 24, 2017 · 2 comments
Assignees
@kevingosse
Labels
area-System.Collections enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Milestone
2.1.0

Comments

@jamesqo
Copy link
Contributor

jamesqo commented Aug 24, 2017

IIRC string does randomized hashing by default in .NET Core so the collections don't need to be modified to use a randomized equality comparer. This code doesn't even compile.
@ianhays
Copy link
Contributor

ianhays commented Sep 11, 2017

going by @ellismg 's comment here, this code should be removed without worry.

@safern
Copy link
Member

safern commented Sep 20, 2017

Fixed in dotnet/corefx#24178

@safern safern closed this as completed Sep 20, 2017
Dotnet-GitSync-Bot referenced this issue in Dotnet-GitSync-Bot/corefx Apr 5, 2019
@safern @dotnet-bot
Nullable: Exception, SystemException, Argument*Exception (#23515)
d91cbf3 
* Nullable: Exception, SystemException, Argument*Exception

* Add Debug.Assert rather than comment

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub referenced this issue in dotnet/corefx Apr 6, 2019
@safern @stephentoub
Nullable: Exception, SystemException, Argument*Exception (#23515)
03446c6 
* Nullable: Exception, SystemException, Argument*Exception

* Add Debug.Assert rather than comment

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevingosse kevingosse

Labels
area-System.Collections enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
5 participants
@ianhays @jamesqo @msftgits @kevingosse @safern