ToolboxBitmapAttributeTests.Ctor_FileName test failed on netfx

[stephentoub]

https://ci3.dot.net/job/dotnet_corefx/job/master/job/windows-TGroup_netfx+CGroup_Release+AGroup_x86+TestOuter_false_prtest/8667/consoleText

      System.Drawing.Tests.ToolboxBitmapAttributeTests.Ctor_FileName(fileName: "D:\\j\\workspace\\windows-TGrou---2a8f9c29\\bin\\t"..., size: {Width=16, Height=16}) [FAIL]
        System.ArgumentException : Parameter is not valid.
        Stack Trace:
             at System.Drawing.Image.get_Width()
             at System.Drawing.Image.get_Size()
             at System.Drawing.Tests.ToolboxBitmapAttributeTests.Ctor_FileName(String fileName, Size size)

[stephentoub]

Failed again here:
https://ci3.dot.net/job/dotnet_corefx/job/master/job/windows-TGroup_netfx+CGroup_Release+AGroup_x86+TestOuter_false_prtest/9306/consoleText

      System.Drawing.Tests.ToolboxBitmapAttributeTests.Ctor_FileName(fileName: "D:\\j\\workspace\\windows-TGrou---2a8f9c29\\bin\\t"..., size: {Width=16, Height=16}) [FAIL]
        System.ArgumentException : Parameter is not valid.
        Stack Trace:
             at System.Drawing.Image.get_Width()
             at System.Drawing.Image.get_Size()
             at System.Drawing.Tests.ToolboxBitmapAttributeTests.Ctor_FileName(String fileName, Size size)

[weshaggard]

I've been seeing the opposite race condition on core runs which I believe I've uncovered and address with dotnet/corefx@1e24a59. After debugging through the tests I finally figured out we have a race condition around the creation these dummy images. I suspect this bug exists on .NET Framework as well, so that leg may still fail and we might need to update the tests accordingly.

[weshaggard]

dotnet/corefx@19f882e updated the tests to handle the netfx behavior as well so there shouldn't be any ordering issues.

[weshaggard]

I included the fix with dotnet/corefx#29148