Strip out SecurityCritical attributes

src/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.X509Name.cs

@@ -90,7 +90,6 @@ private SafeSharedX509NameStackHandle() :
  }
  }
 
- [SecurityCritical]
  internal sealed class SafeX509NameStackHandle : SafeHandle
  {
  private SafeX509NameStackHandle() :

src/Common/src/Interop/Windows/kernel32/Interop.SafeCreateFile.cs

@@ -18,7 +18,6 @@ internal partial class Kernel32
  /// "lpt1:", etc. Use this to avoid security problems, like allowing a web client asking a server
  /// for "http://server/com1.aspx" and then causing a worker process to hang.
  /// </summary>
- [System.Security.SecurityCritical] // auto-generated
  internal static SafeFileHandle SafeCreateFile(
  String lpFileName,
  int dwDesiredAccess,

src/Common/src/Interop/Windows/kernel32/Interop.UnsafeCreateFile.cs

@@ -10,7 +10,6 @@ internal partial class Interop
 {
  internal partial class Kernel32
  {
- [System.Security.SecurityCritical] // auto-generated
  internal static SafeFileHandle UnsafeCreateFile(
  string lpFileName,
  int dwDesiredAccess,

src/Common/src/Microsoft/Win32/SafeHandles/Asn1SafeHandles.Unix.cs

@@ -8,7 +8,6 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeAsn1ObjectHandle : SafeHandle
  {
  private SafeAsn1ObjectHandle() :
@@ -29,7 +28,6 @@ public override bool IsInvalid
  }
  }
 
- [SecurityCritical]
  internal sealed class SafeAsn1BitStringHandle : SafeHandle
  {
  private SafeAsn1BitStringHandle() :
@@ -50,7 +48,6 @@ public override bool IsInvalid
  }
  }
 
- [SecurityCritical]
  internal sealed class SafeAsn1OctetStringHandle : SafeHandle
  {
  private SafeAsn1OctetStringHandle() :
@@ -71,7 +68,6 @@ public override bool IsInvalid
  }
  }
 
- [SecurityCritical]
  internal sealed class SafeAsn1StringHandle : SafeHandle
  {
  private SafeAsn1StringHandle() :

src/Common/src/Microsoft/Win32/SafeHandles/SafeBignumHandle.Unix.cs

@@ -8,7 +8,6 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeBignumHandle : SafeHandle
  {
  private SafeBignumHandle() :

src/Common/src/Microsoft/Win32/SafeHandles/SafeBioHandle.Unix.cs

@@ -9,7 +9,6 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeBioHandle : SafeHandle
  {
  private SafeHandle _parent;

src/Common/src/Microsoft/Win32/SafeHandles/SafeCreateHandle.OSX.cs

@@ -13,7 +13,6 @@ namespace Microsoft.Win32.SafeHandles
  /// if a Create* function is called, the caller must also CFRelease 
  /// on the same pointer in order to correctly free the memory.
  /// </summary>
- [System.Security.SecurityCritical]
  internal sealed partial class SafeCreateHandle : SafeHandle
  {
  internal SafeCreateHandle() : base(IntPtr.Zero, true) { }
@@ -23,7 +22,6 @@ internal SafeCreateHandle(IntPtr ptr) : base(IntPtr.Zero, true)
  this.SetHandle(ptr);
  }
 
- [System.Security.SecurityCritical]
  protected override bool ReleaseHandle()
  {
  Interop.CoreFoundation.CFRelease(handle);
@@ -33,7 +31,6 @@ protected override bool ReleaseHandle()
 
  public override bool IsInvalid
  {
- [System.Security.SecurityCritical]
  get
  {
  return handle == IntPtr.Zero;

src/Common/src/Microsoft/Win32/SafeHandles/SafeDsaHandle.Unix.cs

@@ -9,7 +9,6 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeDsaHandle : SafeHandle
  {
  private SafeDsaHandle() :

src/Common/src/Microsoft/Win32/SafeHandles/SafeEcKeyHandle.Unix.cs

@@ -9,7 +9,6 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeEcKeyHandle : SafeHandle
  {
  private SafeEcKeyHandle() :

src/Common/src/Microsoft/Win32/SafeHandles/SafeEventStreamHandle.OSX.cs

@@ -14,7 +14,6 @@ namespace Microsoft.Win32.SafeHandles
  /// and CFRelease to free; however, FSEventStream has it's own release
  /// function, so we need to extend the pattern to account for that.
  /// </summary>
- [System.Security.SecurityCritical]
  internal sealed partial class SafeEventStreamHandle : SafeHandle
  {
  internal SafeEventStreamHandle() : base(IntPtr.Zero, true) { }
@@ -24,7 +23,6 @@ internal SafeEventStreamHandle(IntPtr ptr) : base(IntPtr.Zero, true)
  this.SetHandle(ptr);
  }
 
- [System.Security.SecurityCritical]
  protected override bool ReleaseHandle()
  {
  Interop.EventStream.FSEventStreamStop(handle);
@@ -36,7 +34,6 @@ protected override bool ReleaseHandle()
 
  public override bool IsInvalid
  {
- [System.Security.SecurityCritical]
  get
  {
  return handle == IntPtr.Zero;

src/Common/src/Microsoft/Win32/SafeHandles/SafeEvpCipherCtxHandle.Unix.cs

@@ -8,15 +8,13 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeEvpCipherCtxHandle : SafeHandle
  {
  private SafeEvpCipherCtxHandle() : 
  base(IntPtr.Zero, ownsHandle: true)
  {
  }
 
- [SecurityCritical]
  protected override bool ReleaseHandle()
  {
  Interop.Crypto.EvpCipherDestroy(handle);
@@ -26,7 +24,6 @@ protected override bool ReleaseHandle()
 
  public override bool IsInvalid
  {
- [SecurityCritical]
  get { return handle == IntPtr.Zero; }
  }
  }

src/Common/src/Microsoft/Win32/SafeHandles/SafeEvpMdCtxHandle.Unix.cs

@@ -8,15 +8,13 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeEvpMdCtxHandle : SafeHandle
  {
  private SafeEvpMdCtxHandle() : 
  base(IntPtr.Zero, ownsHandle: true)
  {
  }
 
- [SecurityCritical]
  protected override bool ReleaseHandle()
  {
  Interop.Crypto.EvpMdCtxDestroy(handle);
@@ -25,7 +23,6 @@ protected override bool ReleaseHandle()
 
  public override bool IsInvalid
  {
- [SecurityCritical]
  get { return handle == IntPtr.Zero; }
  }
  }

src/Common/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs

@@ -8,7 +8,6 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [System.Security.SecurityCritical]
  sealed partial class SafeFileHandle : SafeHandle
  {
  /// <summary>A handle value of -1.</summary>
@@ -80,7 +79,6 @@ internal static SafeFileHandle Open(Func<SafeFileHandle> fdFunc)
  return handle;
  }
 
- [System.Security.SecurityCritical]
  protected override bool ReleaseHandle()
  {
  // When the SafeFileHandle was opened, we likely issued an flock on the created descriptor in order to add 
@@ -108,7 +106,6 @@ protected override bool ReleaseHandle()
 
  public override bool IsInvalid
  {
- [System.Security.SecurityCritical]
  get
  {
  long h = (long)handle;

src/Common/src/Microsoft/Win32/SafeHandles/SafeRsaHandle.Unix.cs

@@ -9,7 +9,6 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeRsaHandle : SafeHandle
  {
  private SafeRsaHandle() :

src/Common/src/Microsoft/Win32/SafeHandles/SafeX509Handles.Unix.cs

@@ -9,7 +9,6 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeX509Handle : SafeHandle
  {
  internal static readonly SafeX509Handle InvalidHandle = new SafeX509Handle();
@@ -19,7 +18,6 @@ private SafeX509Handle() :
  {
  }
 
- [SecurityCritical]
  protected override bool ReleaseHandle()
  {
  Interop.Crypto.X509Destroy(handle);
@@ -29,7 +27,6 @@ protected override bool ReleaseHandle()
 
  public override bool IsInvalid
  {
- [SecurityCritical]
  get { return handle == IntPtr.Zero; }
  }
  }
@@ -54,7 +51,6 @@ public override bool IsInvalid
  }
  }
 
- [SecurityCritical]
  internal sealed class SafeX509StoreHandle : SafeHandle
  {
  private SafeX509StoreHandle() :

src/Common/src/Microsoft/Win32/SafeHandles/SafeX509NameHandle.Unix.cs

@@ -8,7 +8,6 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeX509NameHandle : SafeHandle
  {
  private SafeX509NameHandle() :

src/Common/src/Microsoft/Win32/SafeHandles/X509ExtensionSafeHandles.Unix.cs

@@ -8,7 +8,6 @@
 
 namespace Microsoft.Win32.SafeHandles
 {
- [SecurityCritical]
  internal sealed class SafeX509ExtensionHandle : SafeHandle
  {
  private SafeX509ExtensionHandle() :
@@ -29,7 +28,6 @@ public override bool IsInvalid
  }
  }
 
- [SecurityCritical]
  internal sealed class SafeEkuExtensionHandle : SafeHandle
  {
  private SafeEkuExtensionHandle() :

src/Common/src/System/Diagnostics/Debug.Windows.cs

@@ -20,7 +20,6 @@ static partial class Debug
 
  internal sealed class WindowsDebugLogger : IDebugLogger
  {
- [SecuritySafeCritical]
  public void ShowAssertDialog(string stackTrace, string message, string detailMessage)
  {
  if (Debugger.IsAttached)
@@ -60,7 +59,6 @@ public void WriteCore(string message)
  }
  }
 
- [System.Security.SecuritySafeCritical]
  private static void WriteToDebugger(string message)
  {
  if (Debugger.IsLogging())

src/Common/src/System/Diagnostics/Debug.cs

@@ -88,7 +88,6 @@ public static void Assert(bool condition, string message)
  }
 
  [System.Diagnostics.Conditional("DEBUG")]
- [System.Security.SecuritySafeCritical]
  public static void Assert(bool condition, string message, string detailMessage)
  {
  if (!condition)

src/Common/src/System/StringNormalizationExtensions.Windows.cs

@@ -12,7 +12,6 @@ namespace System
 {
  static partial class StringNormalizationExtensions
  {
- [SecurityCritical]
  public static bool IsNormalized(this string strInput, NormalizationForm normalizationForm)
  {
  if (strInput == null)
@@ -46,7 +45,6 @@ public static bool IsNormalized(this string strInput, NormalizationForm normaliz
  return result;
  }
 
- [SecurityCritical]
  public static string Normalize(this string strInput, NormalizationForm normalizationForm)
  {
  if (strInput == null)

src/Microsoft.VisualBasic/ref/Microsoft.VisualBasic.cs

@@ -198,11 +198,8 @@ public OptionTextAttribute() { }
  public sealed partial class ProjectData
  {
  internal ProjectData() { }
- [System.Security.SecuritySafeCriticalAttribute]
  public static void ClearProjectError() { }
- [System.Security.SecuritySafeCriticalAttribute]
  public static void SetProjectError(System.Exception ex) { }
- [System.Security.SecuritySafeCriticalAttribute]
  public static void SetProjectError(System.Exception ex, int lErl) { }
  }
  [System.AttributeUsageAttribute((System.AttributeTargets)(4), Inherited = false, AllowMultiple = false)]

src/Microsoft.Win32.Registry.AccessControl/ref/Microsoft.Win32.Registry.AccessControl.cs

@@ -8,7 +8,6 @@
 
 namespace Microsoft.Win32
 {
- [System.Security.SecurityCriticalAttribute]
  public static partial class RegistryAclExtensions
  {
  public static System.Security.AccessControl.RegistrySecurity GetAccessControl(this Microsoft.Win32.RegistryKey key) { throw null; }
@@ -18,7 +17,6 @@ public static void SetAccessControl(this Microsoft.Win32.RegistryKey key, System
 }
 namespace System.Security.AccessControl
 {
- [System.Security.SecurityCriticalAttribute]
  public sealed partial class RegistryAccessRule : System.Security.AccessControl.AccessRule
  {
  public RegistryAccessRule(System.Security.Principal.IdentityReference identity, System.Security.AccessControl.RegistryRights registryRights, System.Security.AccessControl.AccessControlType type) : base(default(System.Security.Principal.IdentityReference), default(int), default(bool), default(System.Security.AccessControl.InheritanceFlags), default(System.Security.AccessControl.PropagationFlags), default(System.Security.AccessControl.AccessControlType)) { }
@@ -27,14 +25,12 @@ public sealed partial class RegistryAccessRule : System.Security.AccessControl.A
  public RegistryAccessRule(string identity, System.Security.AccessControl.RegistryRights registryRights, System.Security.AccessControl.InheritanceFlags inheritanceFlags, System.Security.AccessControl.PropagationFlags propagationFlags, System.Security.AccessControl.AccessControlType type) : base(default(System.Security.Principal.IdentityReference), default(int), default(bool), default(System.Security.AccessControl.InheritanceFlags), default(System.Security.AccessControl.PropagationFlags), default(System.Security.AccessControl.AccessControlType)) { }
  public System.Security.AccessControl.RegistryRights RegistryRights { get { throw null; } }
  }
- [System.Security.SecurityCriticalAttribute]
  public sealed partial class RegistryAuditRule : System.Security.AccessControl.AuditRule
  {
  public RegistryAuditRule(System.Security.Principal.IdentityReference identity, System.Security.AccessControl.RegistryRights registryRights, System.Security.AccessControl.InheritanceFlags inheritanceFlags, System.Security.AccessControl.PropagationFlags propagationFlags, System.Security.AccessControl.AuditFlags flags) : base(default(System.Security.Principal.IdentityReference), default(int), default(bool), default(System.Security.AccessControl.InheritanceFlags), default(System.Security.AccessControl.PropagationFlags), default(System.Security.AccessControl.AuditFlags)) { }
  public RegistryAuditRule(string identity, System.Security.AccessControl.RegistryRights registryRights, System.Security.AccessControl.InheritanceFlags inheritanceFlags, System.Security.AccessControl.PropagationFlags propagationFlags, System.Security.AccessControl.AuditFlags flags) : base(default(System.Security.Principal.IdentityReference), default(int), default(bool), default(System.Security.AccessControl.InheritanceFlags), default(System.Security.AccessControl.PropagationFlags), default(System.Security.AccessControl.AuditFlags)) { }
  public System.Security.AccessControl.RegistryRights RegistryRights { get { throw null; } }
  }
- [System.Security.SecurityCriticalAttribute]
  public sealed partial class RegistrySecurity : System.Security.AccessControl.NativeObjectSecurity
  {
  public RegistrySecurity() : base(default(bool), default(System.Security.AccessControl.ResourceType)) { }

src/Microsoft.Win32.Registry.AccessControl/src/Microsoft/Win32/RegistryAclExtensions.cs

@@ -15,7 +15,6 @@ public static RegistrySecurity GetAccessControl(this RegistryKey key)
  return GetAccessControl(key, AccessControlSections.Access | AccessControlSections.Owner | AccessControlSections.Group);
  }
 
- [SecuritySafeCritical]
  public static RegistrySecurity GetAccessControl(this RegistryKey key, AccessControlSections includeSections)
  {
  if (key.Handle == null)
@@ -26,7 +25,6 @@ public static RegistrySecurity GetAccessControl(this RegistryKey key, AccessCont
  return new RegistrySecurity(key.Handle, key.Name, includeSections);
  }
 
- [SecuritySafeCritical]
  public static void SetAccessControl(this RegistryKey key, RegistrySecurity registrySecurity)
  {
  if (registrySecurity == null)

src/Microsoft.Win32.Registry.AccessControl/src/System/Security/AccessControl/RegistrySecurity.cs

@@ -91,13 +91,11 @@ public RegistrySecurity()
  {
  }
 
- [SecurityCritical]
  internal RegistrySecurity(SafeRegistryHandle hKey, string name, AccessControlSections includeSections)
  : base(true, ResourceType.RegistryKey, hKey, includeSections, _HandleErrorCode, null)
  {
  }
 
- [SecurityCritical]
  private static Exception _HandleErrorCode(int errorCode, string name, SafeHandle handle, object context)
  {
  Exception exception = null;
@@ -159,7 +157,6 @@ internal AccessControlSections GetAccessControlSectionsFromChanges()
  return persistRules;
  }
 
- [SecurityCritical]
  internal void Persist(SafeRegistryHandle hKey, string keyName)
  {
  WriteLock();