Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to combine all architectures into one tags table in generated readmes #1497

Closed
lbussell opened this issue Nov 13, 2024 · 3 comments

Comments

@lbussell
Copy link
Contributor

The latest dotnet/samples tags tables are identical between the 3 supported Linux architectures: https://github.com/dotnet/dotnet-docker/blob/96825a00cf9f25c2404337f9785ec1d84d030d86/README.samples.md#full-tag-listing

This is because we undocumented the arch-specific tags since they didn't provide much value for the samples use cases.

Since all of the tables are the same, they are redundant. We should provide some mechanism to combine them all into one table. It could be automatic, or perhaps an extra option in the manifest.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@lbussell
Copy link
Contributor Author

[Triage] There is limited ROI for this change since it only affects the samples images. It would also add additional complexity to the readme generation and make the tags tables less consistent across repos.

We can consider revisiting this/opening another issue once more of the appliance image repos (monitor, aspire dashboard) have tags tables that look similar to this.

@lbussell lbussell closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Docker Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant