Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image info format doesn't separate metadata for multiples images built from the same Dockerfile #286

Closed
mthalman opened this issue Aug 23, 2019 · 1 comment · Fixed by #437

Comments

@mthalman
Copy link
Member

mthalman commented Aug 23, 2019

The image info file keys off of the image's Dockerfile folder path. In the case of the sample projects, there can be a single Dockerfile that is built on multiple platforms, each producing different tags. So when the image info file gets updated with the metadata from these images, that metadata all goes into the same element since the images all share the same Dockerfile folder path. This doesn't currently cause any issues with the image dependency flow system because it only looks up the digests for the images that it cares about and ignores the extraneous other data in the image info file. But from a correctness standpoint, the metadata contained in the image info file should be separated properly.

@mthalman mthalman changed the title Image info format doesn't separate metadata for images built with Dockerfiles in same folder Image info format doesn't separate metadata for multiples images built from the same Dockerfile Aug 28, 2019
@mthalman mthalman self-assigned this Mar 13, 2020
@MichaelSimons
Copy link
Member

Fixed with #437.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants